This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] Re: [PATCH] Modpost section mismatch fix

To: Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>
Subject: Re: [Xen-devel] Re: [PATCH] Modpost section mismatch fix
From: Raghavendra D Prabhu <rprabhu@xxxxxxxxxxx>
Date: Fri, 8 Jul 2011 02:34:29 +0530
Cc: linux-kernel@xxxxxxxxxxxxxxx, Ian Campbell <ijc@xxxxxxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxx, jeremy.fitzhardinge@xxxxxxxxxx, virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx
Delivery-date: Thu, 07 Jul 2011 14:06:38 -0700
Dkim-signature: v=1; a=rsa-sha256; c=simple/simple; d=wnohang.net; s=mail; t=1310072674; bh=UNNZEN4IUPwGzEvAAZXGhYPlZHIMYXHeHBeWLsKl13g=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:In-Reply-To; b=ra+uWRVtflvoTioHaUaFqyovG1DdavM5KkUvoZjn7B7QEjzqTiGgKcdxV8l78D0UV Vc5/jeU/2/IW8huzhFhoDzVChyAEKThYRhRU7V2RGE0YmA5F1Z1CmXGmyv8zHkUFvG p2OgT+A/yPcxO4B5yVsp07dGwy3jK3Ko9LLy1Snw=
Dkim-signature: v=1; a=rsa-sha256; c=simple/simple; d=wnohang.net; s=mail; t=1310072673; bh=UNNZEN4IUPwGzEvAAZXGhYPlZHIMYXHeHBeWLsKl13g=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:In-Reply-To; b=ri0r4dZP2AS6Q/NNTqn3IvOctmrlIqyA3RuQrWyw70rF3W0UVJ+3mVe40fBotdoWo PR2rGUOm/sbguCAyyuTg/fX2naxJHebLub+rybAZ5Diu4LBquCkTD/oGCMoslehC3l a9Lc7seIRFUGK5ErhnSL5cG0gwfWUdJVA5Wfnfhg=
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <20110707200949.GA25216@xxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <1309769388.634.51.camel@xxxxxxxxxxxxxxxxxxxxxx> <20110704221646.GB4490@Xye> <20110705141323.GG2972@xxxxxxxxxxxx> <20110705142731.GA4463@Xye> <20110705144846.GA13548@xxxxxxxxxxxx> <20110705213243.GA3647@xxxxxxxxxxxx> <20110707154648.GA4394@Xye> <20110707162454.GA8164@xxxxxxxxxxxx> <20110707194851.GB4394@Xye> <20110707200949.GA25216@xxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mutt/1.5.21 (2010-12-30)
* On Thu, Jul 07, 2011 at 04:09:49PM -0400, Konrad Rzeszutek Wilk 
<konrad.wilk@xxxxxxxxxx> wrote:
On Fri, Jul 08, 2011 at 01:18:51AM +0530, Raghavendra D Prabhu wrote:
* On Thu, Jul 07, 2011 at 12:24:54PM -0400, Konrad Rzeszutek Wilk 
<konrad.wilk@xxxxxxxxxx> wrote:
>>Tested it. Works now.

>Ok, Stuck Tested-by on the patch. Hopefully Linus hasn't pulled it yet.

>>Reviewed-by: Raghavendra Prabhu <rprabhu@xxxxxxxxxxx>

>>The condition for acpi_gsi_to_irq can be removed since it always returns zero.

>The function might in the future return something that is non-zero
>and we should guard for it. Also you make 'irq' be unsigned which is not
>good as the IRQ 0 is a valid value - and with making it unsigned if it is
>set to -1 (the -1 is the invalid IRQ value) the check for 'irq != gsi'
>will be true and and we will pass in -1 casted to unsigned. That is a
>large value and not the right thing we want to pass to xen_register_gsi.

My rationale for the unsigned part was that acpi_gsi_to_irq always
assigns a positive value (>= 0) to the irq passed (as unsigned
argument). But even otherwise that shouldn't make much of difference I guess.

I had sent another change (oneline) for the file
arch/x86/xen/platform-pci-unplug.c for check_platform_magic, looks like that 
has not gone into
the pull request for Linus.

Oh, I didn't see it. Did you CC me on it? Can you bounce it to me please?

 diff --git a/arch/x86/xen/platform-pci-unplug.c 
 index 25c52f9..ffcf261 100644
 --- a/arch/x86/xen/platform-pci-unplug.c
 +++ b/arch/x86/xen/platform-pci-unplug.c
 @@ -35,7 +35,7 @@ EXPORT_SYMBOL_GPL(xen_platform_pci_unplug);
  static int xen_emul_unplug;

 -static int __init check_platform_magic(void)
 +static int check_platform_magic(void)
         short magic;
         char protocol;

Raghavendra Prabhu
GPG Id : 0xD72BE977
Fingerprint: B93F EBCB 8E05 7039 CD3C A4B8 A616 DCA1 D72B E977
www: wnohang.net

Xen-devel mailing list