WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel] Re: [linux-pm] [PATCH 0/3] xen: Use PM/Hibernate events for

To: Ian Campbell <Ian.Campbell@xxxxxxxxxxxxx>
Subject: [Xen-devel] Re: [linux-pm] [PATCH 0/3] xen: Use PM/Hibernate events for save/restore/chkpt
From: Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>
Date: Fri, 25 Feb 2011 16:23:31 +0000
Cc: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>, Stefano Stabellini <Stefano.Stabellini@xxxxxxxxxxxxx>, "Rafael J. Wysocki" <rjw@xxxxxxx>, Alan Stern <stern@xxxxxxxxxxxxxxxxxxx>, Shriram Rajagopalan <rshriram@xxxxxxxxx>, "linux-pm@xxxxxxxxxxxxxxxxxxxxxxxxxx" <linux-pm@xxxxxxxxxxxxxxxxxxxxxxxxxx>
Delivery-date: Fri, 25 Feb 2011 08:23:31 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <1298650792.5034.551.camel@xxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <Pine.LNX.4.44L0.1102211135170.15325-100000@xxxxxxxxxxxxxxxxxxxx> <1298308650.16356.8102.camel@xxxxxxxxxxxxxxxxxxxxxx> <201102212123.17720.rjw@xxxxxxx> <alpine.DEB.2.00.1102251610160.19277@kaball-desktop> <1298650792.5034.551.camel@xxxxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Alpine 2.00 (DEB 1167 2008-08-23)
On Fri, 25 Feb 2011, Ian Campbell wrote:
> On Fri, 2011-02-25 at 16:17 +0000, Stefano Stabellini wrote:
> > On Mon, 21 Feb 2011, Rafael J. Wysocki wrote:
> > > > For a PV guest only the Xen PV drivers really matter.
> > > > 
> > > > But for a PVHVM guest you are right since there are the emulated "PC"
> > > > devices though which could be problematic. There's nothing especially
> > > > thrilling in that set of devices although I don't think that invalidates
> > > > your point.
> > 
> > This is a genuine concern because it currently breaks save/restore for
> > all PV on HVM guests (dummy_hcd being the offending driver).
> 
> Only if !CONFIG_HIBERNATION, right?

Yes

> > > > > Shouldn't the CONFIG_XEN_SAVE_RESTORE option select 
> > > > > CONFIG_HIBERNATION?
> > > > > In which case the #ifdef lines in pm_op() wouldn't need to be changed.
> > > > 
> > > > I think selecting user-visible symbols is generally frowned upon.
> > > > 
> > > > But apart from that I was concerned that tying the Xen functionality
> > > > into the hibernation option was a bit odd/artificial. Perhaps it's the
> > > > only solution though.
> > > 
> > > I'd very much prefer it if the patchset didn't touch 
> > > drivers/base/power/main.c.
> > > 
> > > However, if you want to select CONFIG_HIBERNATION from 
> > > CONFIG_XEN_SAVE_RESTORE,
> > > you should make sure that CONFIG_HIBERNATION is really selectable (ie.
> > > CONFIG_SWAP is set and CONFIG_ARCH_HIBERNATION_POSSIBLE is set).
> > 
> > I think we should follow this suggestion.
> 
> See the thread "[PATCH] xen: fix XEN_SAVE_RESTORE Kconfig dependencies"
> from Shriram <1298446066-11754-1-git-send-email-rshriram@xxxxxxxxx>

Thanks, I am a bit behind schedule with my unread emails...

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>