Re: [Xen-devel] [PATCH] Fix stubdom-dm using "grep" improperly [

On Tue, 11 Jan 2011, Ian Jackson wrote:
> John Weekes writes ("[Xen-devel] [PATCH] Fix stubdom-dm using "grep" 
> improperly"):
> > stubdom-dm uses "grep" on "xm list" output to determine whether it is 
> > already running. The existing behavior is to use "grep $domname-dm" but 
> > this will result in a false-positive in the case of another domU running 
> > whose name ends with the full new name; for instance, if "abctest-dm" is 
> > running, a new "test-dm" will spin forever, waiting for it the end.
> 
> Urgh.  Thanks for this patch.  This code is pretty horrid stuff, I
> have to say.  I have applied your fix to xen-unstable.
> 
> Keir, can you please also commit this to 4.0-testing ?  It applies
> cleanly.
> 
> Stefano: does xl in stubdom mode still use stubdom-dm ?  If so can it
> please not ?  Certainly "xm list" isn't going to work!

It doesn't.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread]

Current Thread

[Next in Thread>

Previous by Date:

Re: [Xen-devel] Dom0 lockup, Konrad Rzeszutek Wilk

Next by Date:

Re: [Xen-devel] [PATCH] libxl: implement trigger s3resume, Ian Jackson

Previous by Thread:

Re: [Xen-devel] [PATCH] Fix stubdom-dm using "grep" improperly [and 1 more messages], Ian Jackson

Next by Thread:

Re: [Xen-devel] [PATCH] Fix stubdom-dm using "grep" improperly [and 1 more messages], Ian Jackson

Indexes:

[Date] [Thread] [Top] [All Lists]