This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


[Xen-devel] Re: [Qemu-devel] [PATCH V7 00/15] Xen device model support

On 29.11.2010, at 17:06, Anthony PERARD wrote:

> On Mon, 29 Nov 2010, Alexander Graf wrote:
>> On 29.11.2010, at 16:10, Anthony PERARD wrote:
>>> On Mon, 29 Nov 2010, Alexander Graf wrote:
>>>> On 23.11.2010, at 20:51, Anthony.Perard@xxxxxxxxxx wrote:
>>>>> From: Anthony PERARD <anthony.perard@xxxxxxxxxx>
>>>>> Hi all,
>>>>> Here is the V7 of the patch series that adds Xen device model support in 
>>>>> QEMU.
>>>>> The change made on it since the v6:
>>>>> - I introduce a patch from Alexander Graf to add a generic layer for the 
>>>>> Xen calls.
>>>>> - So compatibility support have been transformed from macros to function.
>>>>> - Now, xenfv machine uses a new field default_machine_opts to specify 
>>>>> that Xen will be use.
>>>>> - in xen_init, xen_mode is override to XEN_ATTACH if it was XEN_EMULATE.
>>>> Please try to compile the code on Xen 4.0 :). I'm just trying to rebase 
>>>> xenner against your tree and the build already fails because of missing 
>>>> xen_common.h includes.
>>> :(, I don't have any error with both Xen 4.0.{0,1}.
>>> # Configured with: '../configure' '--target-list=i386-softmmu' 
>>> '--enable-xen' 
>>> '--extra-cflags=-I/tmp/xen/xen-4.0.1/dist/install/usr/include' 
>>> '--extra-ldflags=-L/tmp/xen/xen-4.0.1/dist/install/usr/lib'
>>> Did you use other options with your configure?
>>> Where are the missings includes?
>>> Also, I only compile on 32bits.
>> Ugh. Yes, my bad. It broke in my xenner patches :). Sorry. The issue was 
>> that #include "xen_interfaces.h" without a preceding #include "xen_common.h" 
>> breaks. Maybe it'd be good to move the "xen_common.h" include into "xen.h"? 
>> Doesn't really matter though. I'll try to take on a code review today, so we 
>> can merge the patches asap!
> Actually, it's better to put "#include xen_common.h" in xen_interfaces.h
> because I use stuff from there.

The rest looks very good, so I'm optimistic we'll have a well mergable version 
this week :).


Xen-devel mailing list