WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] wrong vmexit size in xenalyze

To: George Dunlap <George.Dunlap@xxxxxxxxxxxxx>
Subject: Re: [Xen-devel] wrong vmexit size in xenalyze
From: Olaf Hering <olaf@xxxxxxxxx>
Date: Fri, 19 Nov 2010 11:07:12 +0100
Cc: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>, Keir Fraser <keir@xxxxxxx>
Delivery-date: Fri, 19 Nov 2010 02:08:24 -0800
Dkim-signature: v=1; a=rsa-sha1; c=relaxed/relaxed; t=1290161244; l=606; s=domk; d=aepfle.de; h=In-Reply-To:Content-Type:MIME-Version:References:Subject:Cc:To:From: Date:X-RZG-CLASS-ID:X-RZG-AUTH; bh=WCPOD2f+E5fMbwZtEtJMf+meu9c=; b=J0dU1UkZXztPP3HkvDAU4CJND1FYAakYgpcBlQyMfHx+7ABCbuL70cLJlqW39yC9LQc FrCh/uyOB+yk6ZSR2YFzUEzIfIEVseGXBGhGY8IdO4jbirBFi/Nd2tdeNyTcSY4az9aEk enc8wgY7p/Y4oXeKn5nF8af65GsKXuR+05I=
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <4CE6484B.9000707@xxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <C90BF541.A851%keir@xxxxxxx> <4CE6484B.9000707@xxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mutt/1.5.20 (2009-06-14)
On Fri, Nov 19, George Dunlap wrote:

> If you have a better idea, I'm open to it.  A bit more discipline --
> doing an audit of the tracing after the feature freeze before each
> release -- would be helpful; some automated testing would be even
> more helpful.

I think the extra u32 is just padding and can be ignored.
Whats the purpose of the ->extra_bytes checks? If its just a data
integrity check, it can be removed because reading past the end of the
record data should not harm. Maybe limit the loops which iterate
->extra_bytes to 7 because more doesnt fit in a trace record.


Olaf


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel