Re: [Xen-devel] wrong vmexit size in xenalyze

To:	George Dunlap <George.Dunlap@xxxxxxxxxxxxx>
Subject:	Re: [Xen-devel] wrong vmexit size in xenalyze
From:	Keir Fraser <keir@xxxxxxx>
Date:	Fri, 19 Nov 2010 10:05:19 +0000
Cc:	Olaf Hering <olaf@xxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date:	Fri, 19 Nov 2010 02:06:20 -0800
Dkim-signature:	v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:sender:user-agent:date :subject:from:to:cc:message-id:thread-topic:thread-index:in-reply-to :mime-version:content-type:content-transfer-encoding; bh=+jqtL8jJ+AfFHiZLMHpej1zOcw3AOza1pbNRxMlO7v0=; b=bjci2ZDzdImiF7QMJcIyF4ZATwT6tCW19RcM6zkzf+3wAzS5GZ0uRzTg+9f2RlRmEW pKxALPhYVSlM1tsnxw8EHz/Zb0F9EXrKxlxqo693yeABE/Vo+ERmtgeCxshoWoKrJjaP bF/WMF7MUGKPmwnmUaOOtqkPf/I9eLQ5L4x0Q=
Domainkey-signature:	a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=sender:user-agent:date:subject:from:to:cc:message-id:thread-topic :thread-index:in-reply-to:mime-version:content-type :content-transfer-encoding; b=WQ7XGzgx9jHmAjvygnttXvrDHP685NGCcftVrNlAvUyrRYpVz0F2J71jaELhS6Ngl1 cIY9U18+8Nm7AkLGlpdgT2qf8rxncnsypXrJvtoMT7BKP2uWUIWpwk5C99SykdP4/L0O e9+bfwIyyLMN1k+YJdFWG5gY7c8FfH6quqEBY=
Envelope-to:	www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to:	<4CE6484B.9000707@xxxxxxxxxxxxx>
List-help:	<mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id:	Xen developer discussion <xen-devel.lists.xensource.com>
List-post:	<mailto:xen-devel@lists.xensource.com>
List-subscribe:	<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe:	<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender:	xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index:	AcuH0UVBPaNTh91AI0eghPhMSSZD2A==
Thread-topic:	[Xen-devel] wrong vmexit size in xenalyze
User-agent:	Microsoft-Entourage/12.27.0.100910

On 19/11/2010 09:50, "George Dunlap" <George.Dunlap@xxxxxxxxxxxxx> wrote:

> Yeah, doing some archeology... looks like the trace size for the
> HVMTRACE_ND macro is has an off-by-one error since domain_id and vcpu_id
> were removed from HVM trace records in September 2008.
> 
> Tracing is definitely not a stable ABI between releases, but it should
> be reasonably stable after a release.
> 
> Originally I tried having xenalyze detect and deal with different trace
> layouts, but it made the code just too much of a mess.  I could have
> simply tagged xenalyze on a release, but then future improvements to
> xenalyze wouldn't be able to be used on released versions of Xen.

If there are a broader range of incompatibilties between 4.0 and 4.1 then
that makes sense. If the interface is pretty stable now, and it's just one
or two things like this, then maybe it was worth handling automatically.

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

WARNING - OLD ARCHIVES

xen-devel

Re: [Xen-devel] wrong vmexit size in xenalyze