WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH 07/16] xenpaging: populate only paged-out pages

To: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH 07/16] xenpaging: populate only paged-out pages
From: Olaf Hering <olaf@xxxxxxxxx>
Date: Wed, 10 Nov 2010 09:37:35 +0100
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Wed, 10 Nov 2010 00:38:19 -0800
Dkim-signature: v=1; a=rsa-sha1; c=relaxed/relaxed; t=1289378262; l=1045; s=domk; d=aepfle.de; h=In-Reply-To:Content-Type:MIME-Version:References:Subject:Cc:To:From: Date:X-RZG-CLASS-ID:X-RZG-AUTH; bh=5ysKAm2AalcKnqAnvGYl2E5G2iY=; b=GIKuQO7N3RHEpyc9PTDcMp3KMBrR9aYNB3Z8LXpRPyW1jV//O3qwRLAccE6eoNhA8Mj awKr4bTafdpNJTvQxVy4Ar7jN6+USyZXF+Tus16oFbDd9pr+a/g23kEpB5MhAUv0C0zhS 14KstwW1jgzxccMeI4kmvTVY11BqfZ7Ihak=
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <20101109104039.GA20253@xxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <20101102223010.603002116@xxxxxxxxx> <20101102223013.193448172@xxxxxxxxx> <19665.22499.347592.712902@xxxxxxxxxxxxxxxxxxxxxxxx> <20101109104039.GA20253@xxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mutt/1.5.20 (2009-06-14)
On Tue, Nov 09, Olaf Hering wrote:

> The other thing is that p2m_mem_paging_populate must only invalidate the
> mfn if either the page is still in the process of being paged out, or if
> the page is already in the process of being paged in. The latter does
> not happen right now. The result is that the page may have state
> p2m_ram_paging_in and a new valid mfn. Then that new mfn is invalidated,
> the gfn content in the xenpaging process was already overwritten and
> there is no wakeup of the vcpu. This situation is not recoverable.
> p2m.c:p2m_mem_paging_populate needs a change to no call set_p2m_entry if
> the p2mt state is already p2m_ram_paging_in

And even this is not perfect.
p2m_mem_paging_populate() could be called again even if the p2m state was
just set to p2m_ram_rw in p2m_mem_paging_resume(). In this case the thread who 
calls
p2m_mem_paging_populate() cant make any progress anymore.
So in the end, p2m_mem_paging_populate() can only invalidate the mfn if
the p2mt happens to be p2m_ram_paged.

Olaf


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>