WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH 07/16] xenpaging: populate only paged-out pages

To: Olaf Hering <olaf@xxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH 07/16] xenpaging: populate only paged-out pages
From: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
Date: Wed, 3 Nov 2010 12:38:59 +0000
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Wed, 03 Nov 2010 05:41:35 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <20101102223013.193448172@xxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Newsgroups: chiark.mail.xen.devel
References: <20101102223010.603002116@xxxxxxxxx> <20101102223013.193448172@xxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Olaf Hering writes ("[Xen-devel] [PATCH 07/16] xenpaging: populate only 
paged-out pages"):
> populdate a paged-out page only once to reduce pressure in the ringbuffer.
> Several cpus may still request a page at once. xenpaging can handle this.
>
> But: maybe this will miss pages in paging-out state?

I can't answer your second question, but surely this pattern:

> -        p2m_mem_paging_populate(p2m, ram_gfn);
> +        if ( p2m_is_paged(p2mt) )
> +            p2m_mem_paging_populate(p2m, ram_gfn);

would better be done inside p2m_mem_paging_populate ?  Unless there
are some calls to _populate which should skip the check ?

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>