WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [Patch][resend] implementation of cpupool support in xl

To: Ian Campbell <Ian.Campbell@xxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [Patch][resend] implementation of cpupool support in xl
From: Juergen Gross <juergen.gross@xxxxxxxxxxxxxx>
Date: Wed, 15 Sep 2010 13:28:05 +0200
Cc:
Delivery-date: Wed, 15 Sep 2010 04:29:14 -0700
Dkim-signature: v=1; a=rsa-sha256; c=simple/simple; d=ts.fujitsu.com; i=juergen.gross@xxxxxxxxxxxxxx; q=dns/txt; s=s1536b; t=1284550100; x=1316086100; h=message-id:date:from:mime-version:to:subject:references: in-reply-to; z=Message-ID:=20<4C90ADC5.80202@xxxxxxxxxxxxxx>|Date:=20We d,=2015=20Sep=202010=2013:28:05=20+0200|From:=20Juergen =20Gross=20<juergen.gross@xxxxxxxxxxxxxx>|MIME-Version: =201.0|To:=20Ian=20Campbell=20<Ian.Campbell@xxxxxxxxxx>, =20=0D=0A=20"xen-devel@xxxxxxxxxxxxxxxxxxx"=20<xen-devel@ lists.xensource.com>|Subject:=20Re:=20[Xen-devel]=20[Patc h][resend]=20implementation=20of=20cpupool=20support=0D =0A=20in=20xl|References:=20<4C907510.3070904@xxxxxxxxxxx com>=09<1284539351.14311.18361.camel@xxxxxxxxxxxxxxxxxxxx om>=09<4C9087B7.4090205@xxxxxxxxxxxxxx>=09<1284542187.143 11.18454.camel@xxxxxxxxxxxxxxxxxxxxxx>=09<4C90909F.707070 0@xxxxxxxxxxxxxx>=09<1284543448.14311.18480.camel@xxxxxxx k.xensource.com>=20<1284546138.14311.18568.camel@xxxxxxxx .xensource.com>|In-Reply-To:=20<1284546138.14311.18568.ca mel@xxxxxxxxxxxxxxxxxxxxxx>; bh=kytJMo0hyOUj42I9em/Ayzi/bgB17uro9XfIvF848SE=; b=mYUnwihkxRwGHN4PotrcChGCYZsvx8e0x5wtB5RfjhfNtcdb4ssA3yQO JzQEUnzdZ6X5T7ZrtsadBGEqNEigWZsjEiEngkZ77OaSsK/VQuijF9jgT pUQ/kX2Sn95m3Cz7n6BwIyjKOfftIZ95c7b2BO/H+PMJnHigQ6rOY5nd6 //+8VmzzehvC7GRAiw94dUSLhVDxm80mXuagpiJOGMFTlvUNJdfVwbLPl zZEaKF17JpEeyUe3s7bz31/m66kz5;
Domainkey-signature: s=s1536a; d=ts.fujitsu.com; c=nofws; q=dns; h=X-SBRSScore:X-IronPort-AV:Received:X-IronPort-AV: Received:Received:Message-ID:Date:From:Organization: User-Agent:MIME-Version:To:Subject:References:In-Reply-To: Content-Type; b=hu9bCpekVJ8tHOXnnukVn2LsKRirZkwG2sNyC2KyIp33kJgspPTgF25+ gJGUeE0AR9FCv9Pna/cotYIpWun/C+3oSRaMVt7FqJiVLC+vtxE8+cqaL t9mpOumSODuUOlrOyoIjLqPEEkpAahFk7Ozt94a07sp4qrfrtKIMbiGAc 85Wmwgv4D1Ie3l7g9AkyOydnRjlU6YRAeov9gwbl/KueAQPkIo021JmON /BiA9dJGNTXeyi7+WdUp9dWVB9t71;
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <1284546138.14311.18568.camel@xxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Organization: Fujitsu Technology Solutions
References: <4C907510.3070904@xxxxxxxxxxxxxx> <1284539351.14311.18361.camel@xxxxxxxxxxxxxxxxxxxxxx> <4C9087B7.4090205@xxxxxxxxxxxxxx> <1284542187.14311.18454.camel@xxxxxxxxxxxxxxxxxxxxxx> <4C90909F.7070700@xxxxxxxxxxxxxx> <1284543448.14311.18480.camel@xxxxxxxxxxxxxxxxxxxxxx> <1284546138.14311.18568.camel@xxxxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.11) Gecko/20100805 Iceowl/1.0b1 Icedove/3.0.6
On 09/15/10 12:22, Ian Campbell wrote:
On Wed, 2010-09-15 at 10:37 +0100, Ian Campbell wrote:
On Wed, 2010-09-15 at 10:23 +0100, Juergen Gross wrote:

And I'm not sure I'll get the generating of the bindings correctly.
So yes, please do it!

Will do.

> From looking at your patch it seems that the intention is that the size
is the number of bytes in the map, rather than the number of CPUs which
can be represented or the number of uint64_t's, is that right and/or
what you would like to use?

Seems like libxc counts bytes but libxl (with your patch) counts 64 bit
words.

There doesn't seem to be any users of the size currently so I went with
bytes in the below (compile tested + examined generated code only) but
since your patch adds the first actual user feel free to change it if
that makes the libxl interface more suitable for your needs or whatever.

Thanks, updated patch is attached.
I didn't add the destructor, because this would have made things much more
complicated as libxl_list_pool returns an array of libxl_poolinfo elements.
Doing only one free() at caller side is much easier than cycling through
the elements and free-ing all extra allocated cpumaps.


Juergen

--
Juergen Gross                 Principal Developer Operating Systems
TSP ES&S SWE OS6                       Telephone: +49 (0) 89 3222 2967
Fujitsu Technology Solutions              e-mail: juergen.gross@xxxxxxxxxxxxxx
Domagkstr. 28                           Internet: ts.fujitsu.com
D-80807 Muenchen                 Company details: ts.fujitsu.com/imprint.html

Attachment: xl-pools.patch
Description: Text Data

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
<Prev in Thread] Current Thread [Next in Thread>