This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


[Xen-devel] Re: [Pkg-xen-devel] using xen tools with python2.6

To: Ian Campbell <Ian.Campbell@xxxxxxxxxx>
Subject: [Xen-devel] Re: [Pkg-xen-devel] using xen tools with python2.6
From: Matthias Klose <doko@xxxxxxxxxx>
Date: Tue, 14 Sep 2010 17:55:43 +0200
Cc: xen@xxxxxxxxxxxxxxxxxxx, xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Tue, 14 Sep 2010 08:58:21 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <1284369251.14311.14322.camel@xxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <4C8CE2BD.2000404@xxxxxxxxxx> <1284367127.14311.14256.camel@xxxxxxxxxxxxxxxxxxxxxx> <4C8DE78B.10709@xxxxxxxxxx> <1284369251.14311.14322.camel@xxxxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv: Gecko/20100903 Thunderbird/3.1.3
On 13.09.2010 11:14, Ian Campbell wrote:
On Mon, 2010-09-13 at 10:57 +0200, Matthias Klose wrote:
On 13.09.2010 10:38, Ian Campbell wrote:
On Sun, 2010-09-12 at 16:25 +0200, Matthias Klose wrote:
there are at least some syntax errors when trying to use the xen utils with
python2.6.  The attached patch changes these string exception into ValueError's.

Thanks Matthias.

    - tools/python/xen/util/bugtool.py (getBugTitle)
    - tools/python/xen/xend (class XendBase): not catched
    - tools/python/xen/xm/xenapi_create.py (sxp2xmlconvert_sxp_to_xml):
      the method already raises a ValueError for similiar condition.
    - tools/python/xen/xm/main.py (xm_network_attach): not catched.

For all but maybe the first one, the replacement of the string exceptions into
ValueError's seems to be safe.

Why is the first one potentially unsafe?

because I didn't check where it's used.

What do you mean by "not catched" here? Just that nothing catches the

yes, and the first one seems to match this definition too.

I suspect so too, I think these changes are good.

Please could you provide a Signed-off-by line for upstream?

hmm, any pointers? I hope my friendly distribution packager could help ...

As with the Linux kernel Xen requires that contributions are signed off
to indicate that the code is suitable (copyright-wise etc) for inclusion
in Xen. e.g.
    Signed-off-by: Ian Campbell<ian.campbell@xxxxxxxxxxxxx>
except with your name and email address.

You can find the precise meaning in the Linux
upstream kernel tree (Documentation/SubmittingPatches, copy below).

thanks, attached the patch with this line added.


Attachment: tools-python2.6.diff
Description: Text document

Xen-devel mailing list