This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


[Xen-devel] Re: [Pkg-xen-devel] using xen tools with python2.6

To: Matthias Klose <doko@xxxxxxxxxx>
Subject: [Xen-devel] Re: [Pkg-xen-devel] using xen tools with python2.6
From: Ian Campbell <Ian.Campbell@xxxxxxxxxx>
Date: Mon, 13 Sep 2010 10:14:11 +0100
Cc: xen@xxxxxxxxxxxxxxxxxxx, xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Mon, 13 Sep 2010 02:15:00 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <4C8DE78B.10709@xxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Organization: Citrix Systems, Inc.
References: <4C8CE2BD.2000404@xxxxxxxxxx> <1284367127.14311.14256.camel@xxxxxxxxxxxxxxxxxxxxxx> <4C8DE78B.10709@xxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
On Mon, 2010-09-13 at 10:57 +0200, Matthias Klose wrote:
> On 13.09.2010 10:38, Ian Campbell wrote:
> > On Sun, 2010-09-12 at 16:25 +0200, Matthias Klose wrote:
> >> there are at least some syntax errors when trying to use the xen utils with
> >> python2.6.  The attached patch changes these string exception into 
> >> ValueError's.
> >
> > Thanks Matthias.
> >
> >>    - tools/python/xen/util/bugtool.py (getBugTitle)
> >>    - tools/python/xen/xend (class XendBase): not catched
> >>    - tools/python/xen/xm/xenapi_create.py (sxp2xmlconvert_sxp_to_xml):
> >>      the method already raises a ValueError for similiar condition.
> >>    - tools/python/xen/xm/main.py (xm_network_attach): not catched.
> >>
> >> For all but maybe the first one, the replacement of the string exceptions 
> >> into
> >> ValueError's seems to be safe.
> >
> > Why is the first one potentially unsafe?
> because I didn't check where it's used.
> > What do you mean by "not catched" here? Just that nothing catches the
> > exception?
> yes, and the first one seems to match this definition too.

I suspect so too, I think these changes are good.
> > Please could you provide a Signed-off-by line for upstream?
> hmm, any pointers? I hope my friendly distribution packager could help ...

As with the Linux kernel Xen requires that contributions are signed off
to indicate that the code is suitable (copyright-wise etc) for inclusion
in Xen. e.g.
   Signed-off-by: Ian Campbell <ian.campbell@xxxxxxxxxxxxx>
except with your name and email address.

You can find the precise meaning in the Linux
upstream kernel tree (Documentation/SubmittingPatches, copy below).


       Developer's Certificate of Origin 1.1

        By making a contribution to this project, I certify that:

        (a) The contribution was created in whole or in part by me and I
            have the right to submit it under the open source license
            indicated in the file; or

        (b) The contribution is based upon previous work that, to the best
            of my knowledge, is covered under an appropriate open source
            license and I have the right under that license to submit that
            work with modifications, whether created in whole or in part
            by me, under the same open source license (unless I am
            permitted to submit under a different license), as indicated
            in the file; or

        (c) The contribution was provided directly to me by some other
            person who certified (a), (b) or (c) and I have not modified

        (d) I understand and agree that this project and the contribution
            are public and that a record of the contribution (including all
            personal information I submit with it, including my sign-off) is
            maintained indefinitely and may be redistributed consistent with
            this project or the open source license(s) involved.

Xen-devel mailing list