This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


RE: [Xen-devel] [PATCH 06/16] vmx: nest: handling VMX instruction exits

To: Tim Deegan <Tim.Deegan@xxxxxxxxxx>
Subject: RE: [Xen-devel] [PATCH 06/16] vmx: nest: handling VMX instruction exits
From: "Dong, Eddie" <eddie.dong@xxxxxxxxx>
Date: Mon, 13 Sep 2010 22:29:37 +0800
Accept-language: en-US
Acceptlanguage: en-US
Cc: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>, "Dong, Eddie" <eddie.dong@xxxxxxxxx>, "He, Qing" <qing.he@xxxxxxxxx>
Delivery-date: Mon, 13 Sep 2010 07:34:32 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <20100913111130.GE3844@xxxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <1283959344-3837-1-git-send-email-qing.he@xxxxxxxxx> <1283959344-3837-7-git-send-email-qing.he@xxxxxxxxx> <1A42CE6F5F474C41B63392A5F80372B22A86D1F9@xxxxxxxxxxxxxxxxxxxxxxxxxxxx> <20100913111130.GE3844@xxxxxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: ActTNG40NGaZZyvFSW+0N3LUoSIYkAAG3Ppg
Thread-topic: [Xen-devel] [PATCH 06/16] vmx: nest: handling VMX instruction exits
Tim Deegan wrote:
> At 08:05 +0100 on 10 Sep (1284105901), Dong, Eddie wrote:
>> Qing He wrote:
>>> +static int __clear_current_vvmcs(struct vmx_nest_struct *nest) +{
>>> +    int rc;
>>> +
>>> +    if ( nest->svmcs )
>>> +        __vmpclear(virt_to_maddr(nest->svmcs));
>>> +
>>> +    rc = hvm_copy_to_guest_phys(nest->gvmcs_pa, nest->vvmcs,
>> Qing:
>>      Why this may be failure? The only reason may be nest->gvmcs_pa, but
>> I guess we already verified the address. 
> It was verified at load time, but the guest could have ballooned it
> out in the meantime.

If the L1 guest allocated that GPA as VMCS memory, it can't balloon them out.
If L1 is a mallicious guest and ballooned the VMCS memory out, it is worthy to 
do. Not?

> Cheers,

Thx, Eddie
Xen-devel mailing list

<Prev in Thread] Current Thread [Next in Thread>