[Xen-devel] [PATCH] Fix mce erst bug to pass build under i386

["Liu, Jinsong" <jinsong.liu@xxxxxxxxx>]

Ian Jackson wrote:
> Ian Jackson writes ("[xen-unstable test] 2042: regressions - FAIL"):
>> flight 2042 xen-unstable real
>> http://www.chiark.greenend.org.uk/~xensrcts/logs/2042/
>> 
>> Regressions :-(
>> 
>> tests which did not succeed:
>>  build-i386                    3 xen-build               fail REGR.
>> vs. 2017 
> 
> This is due to the following compile error:
> 
>   .../xen/include/xen/cper.h: In function 'cper_next_record_id':
>   .../xen/include/xen/cper.h:44: error: left shift count >= width of
> type 
> 
> This was introduced in 22053:3bd6d29f1435 "mce: Provide ERST
> interface".  The compiler is correct:
> 
> +extern unsigned long get_sec(void);
> ...
> +               record_id = get_sec() << 32;
> 
> If the intent is really just to initialise the top 32 bits with a
> 32-bit number, then you should write something like this:
>                 record_id = (u64)get_sec() << 32;
> 
> Ian.

Thanks, fix patch attached.

Jinsong

mce-erst-fix.patch
Description: mce-erst-fix.patch

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel