WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel] Re: [xen-unstable test] 2042: regressions - FAIL

To: Jinsong Liu <jinsong.liu@xxxxxxxxx>
Subject: [Xen-devel] Re: [xen-unstable test] 2042: regressions - FAIL
From: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
Date: Mon, 23 Aug 2010 11:02:10 +0100
Cc: Keir, "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>, Fraser <Keir.Fraser@xxxxxxxxxxxxx>
Delivery-date: Mon, 23 Aug 2010 03:13:47 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <E1OnIZm-0002Ik-IP@xxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <E1OnIZm-0002Ik-IP@xxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Ian Jackson writes ("[xen-unstable test] 2042: regressions - FAIL"):
> flight 2042 xen-unstable real
> http://www.chiark.greenend.org.uk/~xensrcts/logs/2042/
> 
> Regressions :-(
> 
> tests which did not succeed:
>  build-i386                    3 xen-build               fail REGR. vs. 2017

This is due to the following compile error:

  .../xen/include/xen/cper.h: In function 'cper_next_record_id':
  .../xen/include/xen/cper.h:44: error: left shift count >= width of type

This was introduced in 22053:3bd6d29f1435 "mce: Provide ERST
interface".  The compiler is correct:

+extern unsigned long get_sec(void);
...
+               record_id = get_sec() << 32;

If the intent is really just to initialise the top 32 bits with a
32-bit number, then you should write something like this:
                record_id = (u64)get_sec() << 32;

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>