Re: [xen-devel][vNUMA v2][PATCH 2/8] public interface
I don't see a problem with this situation. The guest has virtual nodes,
these can be mapped in any way to actual physical nodes (but only by the
hypervisor/Dom0, not by the guest itself).
A corner case could be clearly to map all guest nodes to one single host
node. In terms of performance this should be even better, if the new
host can satisfy the requirement from one node, because there will be no
remote accesses at all.
On Tue, Aug 3, 2010 at 8:52 AM, Keir Fraser <keir.fraser@xxxxxxxxxxxxx> wrote:
On 03/08/2010 16:43, "Dulloor" <dulloor@xxxxxxxxx> wrote:
I would expect guest would see nodes 0 to nr_vnodes-1, and the mnode_id
could go away.
mnode_id maps the vnode to a particular physical node. This will be
used by balloon driver in
the VMs when the structure is passed as NUMA enlightenment to PVs and
PV on HVMs.
I have a patch ready for that (once we are done with this series).
So what happens when the guest is migrated to another system with different
physical node ids? Is that never to be supported? I'm not sure why you
wouldn't hide the vnode-to-mnode translation in the hypervisor.
Right now, migration is not supported when NUMA strategy is set.
This is in my TODO list (along with PoD support).
There are a few open questions wrt migration :
- What if the destination host is not NUMA, but the guest is NUMA. Do we fake
those nodes ? Or, should we not select such a destination host to begin with.
Most people deal with NUMA because they want to cure performance _drops_
caused by bad allocation policies. After all NUMA awareness is a
performance optimization. If the user asks to migrate to another host,
then we shouldn't come with fussy argument like NUMA. In my eyes it is a
question of priorities, I don't want to deny migration because of this.
- What if the destination host is not NUMA, but guest has asked to be
a specific number of nodes (possibly for higher aggregate memory bandwidth) ?
I see, there is one case where the new host has more nodes than the old
one, but the memory on each node is not sufficient (like migrating from
a 2*8GB machine to an 8*4GB one). I think we should inform the user
about this and if she persists in the migration, use some kind of
interleaving to join two (or more) nodes together. Looks like future
- What if the guest has asked for a particular memory strategy
but the destination host can't guarantee that (because of the
distribution of free memory
across the nodes) ?
I was afraid you were saying that ;-) I haven't thought about this in
detail, but maybe we can make an exception for Dom0 only, because this
is the most prominent and frequent user of ballooning. But I really
think that DomUs should not know about or deal with host NUMA nodes.
Once we answer these questions, we will know whether vnode-to-mnode
translation is better
exposed or not. And, if exposed, could we just renegotiate the
vnode-to-mnode translation at the
destination host. I have started working on this. But, I have some
other patches ready to go
which we might want to check-in first - PV/Dom0 NUMA patches,
Ballooning support (see below).
As such, the purpose of vnode-to-mnode translation is for the enlightened
guests to know where their underlying memory comes from, so that
like ballooning are given a chance to maintain this distribution.
AMD-Operating System Research Center (OSRC), Dresden, Germany
Tel: +49 351 448-3567-12
Xen-devel mailing list