WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] I cannot get any message from domU by console / pv_ops d

To: Ian Campbell <Ian.Campbell@xxxxxxxxxx>
Subject: Re: [Xen-devel] I cannot get any message from domU by console / pv_ops domU kernel crashes with xen_create_contiguous_region failed
From: Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>
Date: Tue, 22 Dec 2009 13:08:20 -0500
Cc: Jeremy Fitzhardinge <jeremy@xxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>, ?????? <peb1611@xxxxxxxxx>
Delivery-date: Tue, 22 Dec 2009 10:16:40 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <1261504973.5965.7226.camel@xxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <ebf0d9030912212002h6996f725kf4626bd02e03161b@xxxxxxxxxxxxxx> <20091222084214.GR16033@xxxxxxxxxxx> <1261473615.5965.3829.camel@xxxxxxxxxxxxxxxxxxxxxx> <20091222143540.GB2785@xxxxxxxxxxxxxxxxxxx> <1261493401.5965.5944.camel@xxxxxxxxxxxxxxxxxxxxxx> <20091222154747.GC5181@xxxxxxxxxxxxxxxxxxx> <1261498176.5965.6477.camel@xxxxxxxxxxxxxxxxxxxxxx> <20091222161919.GA6426@xxxxxxxxxxxxxxxxxxx> <20091222165905.GA13650@xxxxxxxxxxxxxxxxxxx> <1261504973.5965.7226.camel@xxxxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mutt/1.5.19 (2009-01-05)
> >  void __init xen_swiotlb_init(void)
> >  {
> > -   if (xen_domain()) {
> > +        int use_swiotlb = 0;
> > +
> > +        if (xen_initial_domain())
> > +                use_swiotlb = 1;
> > +
> > +        /* For PV guest, only if iommu=soft is passed in. */
> > +        if (xen_pv_domain() && !xen_initial_domain() && swiotlb)
> > +               use_swiotlb = 1;
> > + 
> > +   if (use_swiotlb) {
> 
> How about just 
>         if (xen_pv_domain() && (xen_initial_domain() || swiotlb))

That would work too. Let me remake the patch as it also has
spaces instead of tabs and fails the checkpatch.pl.

> Or depending on how/where swiotlb gets set (i.e. if it is set IFF
> xen_pv_domain) simply:
>         if (xen_initial_domain() || swiotlb)

Can't do that, as it could on baremetal allocate the Xen-SWIOTLB.

> 
> Ian.
> 

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>