WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel] [PATCH 9/9] In pci_frontend_disable_msi do not alter the dev

To: xen-devel@xxxxxxxxxxxxxxxxxxx
Subject: [Xen-devel] [PATCH 9/9] In pci_frontend_disable_msi do not alter the dev->irq.
From: Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>
Date: Mon, 9 Nov 2009 16:17:39 -0500
Cc: Jeremy Fitzhardinge <jeremy@xxxxxxxx>, Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>
Delivery-date: Mon, 09 Nov 2009 13:27:57 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <1257801459-19404-9-git-send-email-konrad.wilk@xxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <1257801459-19404-1-git-send-email-konrad.wilk@xxxxxxxxxx> <1257801459-19404-2-git-send-email-konrad.wilk@xxxxxxxxxx> <1257801459-19404-3-git-send-email-konrad.wilk@xxxxxxxxxx> <1257801459-19404-4-git-send-email-konrad.wilk@xxxxxxxxxx> <1257801459-19404-5-git-send-email-konrad.wilk@xxxxxxxxxx> <1257801459-19404-6-git-send-email-konrad.wilk@xxxxxxxxxx> <1257801459-19404-7-git-send-email-konrad.wilk@xxxxxxxxxx> <1257801459-19404-8-git-send-email-konrad.wilk@xxxxxxxxxx> <1257801459-19404-9-git-send-email-konrad.wilk@xxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
The MSI subsystem keeps track of the IRQ number before enabling
MSI and it will write the old IRQ once it has completed disabling
MSI functionality of the device.

Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>
---
 drivers/pci/xen-pcifront.c |    4 +---
 1 files changed, 1 insertions(+), 3 deletions(-)

diff --git a/drivers/pci/xen-pcifront.c b/drivers/pci/xen-pcifront.c
index ca95b23..cc3b51b 100644
--- a/drivers/pci/xen-pcifront.c
+++ b/drivers/pci/xen-pcifront.c
@@ -368,9 +368,7 @@ void pci_frontend_disable_msi(struct pci_dev *dev)
                printk(KERN_DEBUG "get no response from backend for disable 
MSI\n");
                return;
        }
-       if (likely(!err))
-               dev->irq = op.value;
-       else
+       if (err)
                /* how can pciback notify us fail? */
                printk(KERN_DEBUG "get fake response frombackend \n");
 }
-- 
1.6.2.5


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel