WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH] 1 of 5: secondary consoles in minos

To: Dulloor <dulloor@xxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] 1 of 5: secondary consoles in minos
From: Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>
Date: Mon, 15 Jun 2009 10:49:29 +0100
Cc: xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Mon, 15 Jun 2009 02:45:48 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <940bcfd20906112155v1f86fdcif0d8d7131dde31d0@xxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <4A311DC7.6080801@xxxxxxxxxxxxx> <940bcfd20906112155v1f86fdcif0d8d7131dde31d0@xxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Thunderbird 2.0.0.14 (X11/20080505)
Dulloor wrote:

> For completeness, we should be freeing up memory(malloced for dev) in
> case of an error in xencons_ring_init. There could be other such instances.

Good point.

> Also, is it too difficult to create a consfront_dev for the first
> console and get rid of those !dev checks.


No, it is not difficult, I actually wrote it that way the first time.
However I would need to keep the checks anyway because the first console
is used even before init_console is called. Therefore I decided to avoid
calling init_console for the first console and use the !dev checks for it.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel