WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

RE: [Xen-devel] [PATCH] DOM0: Adding MCA Loging support in DOM0

Thanks - looks goo now to me (i.e. Acked-by: Jan Beulich <jbeulich@xxxxxxxxxx>
if we have such a concept in Xen).

Jan

>>> "Ke, Liping" <liping.ke@xxxxxxxxx> 15.06.09 09:49 >>>
Hi, Jan

Thanks a lot! I modified them and resent it.

Regards,
Criping



>> config X86_MCE
>> -    bool "Machine check support" if EMBEDDED
>> -    depends on !X86_64_XEN
>> -    default y
>> +    bool "Machine check support"
>> +    depends on (!XEN_UNPRIVILEGED_GUEST)
>> +    default n
>>      help
>>         Include a machine check error handler to report hardware errors.
>>         This version will require the mcelog utility to decode some
> 
> Once again you change a default value here for no apparent reason.

I originally plan not enable this option by default. But yes, it's fine to 
enable it.

>> +#ifndef CONFIG_X86_64_XEN
>>      mce_cpu_features(c);
>> +#endif
>> }
>> 
>> /*
> 
> This conditional can be avoided if the preceding one would be moved
> inside the function (to cover just the entire function body).

Yes. I will change it.

> 
> g_mi appears to be no longer used outside of
> arch/x86_64/kernel/mce_dom0.c, so it could be (statically) defined
> there instead of here. 
> 

Yes. I need to clean this code after changes.

> Jan



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel