WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

RE: [Xen-devel] [PATCH] DOM0: Adding MCA Loging support in DOM0

To: Jan Beulich <JBeulich@xxxxxxxxxx>, "Jiang, Yunhong" <yunhong.jiang@xxxxxxxxx>
Subject: RE: [Xen-devel] [PATCH] DOM0: Adding MCA Loging support in DOM0
From: "Ke, Liping" <liping.ke@xxxxxxxxx>
Date: Thu, 11 Jun 2009 10:42:53 +0800
Accept-language: en-US
Acceptlanguage: en-US
Cc: xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Wed, 10 Jun 2009 19:44:08 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <4A2FA418020000780000529A@xxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <E2263E4A5B2284449EEBD0AAB751098402CB91D657@xxxxxxxxxxxxxxxxxxxxxxxxxxxx> <4A2FA418020000780000529A@xxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AcnptFtARqVSbxxlTZ2ltFf08RFJ1wAex5gg
Thread-topic: [Xen-devel] [PATCH] DOM0: Adding MCA Loging support in DOM0
Hi, Jan

Thanks a lot for the detailed review!
I resend the verified patch according to the below agreement.

Regards,
Criping

Jan Beulich wrote:
>>>> --- a/arch/x86_64/Kconfig  Tue Jun 09 09:58:11 2009 +0800
>>>> +++ b/arch/x86_64/Kconfig  Wed Jun 10 14:12:55 2009 +0800 @@ -472,7
>>>> +472,6 @@ 
>>>> 
>>>> config X86_MCE
>>>>    bool "Machine check support" if EMBEDDED
>>>> -  depends on !X86_64_XEN
>>>>    default y
>>>>    help
>>>>       Include a machine check error handler to report hardware
>>>> errors. 
>>> 
>>> Shouldn't this rather change the dependency to XEN_PRIVILEGED_GUEST?
>>> 
>> Native depends on this config too, so have about change it like this
>> depends on   !X86_64_XEN || ( X86_64_XEN && XEN_PRIVILEGED_GUEST)
> 
> Oh, right. But then why not simply using !XEN_UNPRIVILEGED_GUEST?

Yes, it's very nice.

> 
>>>> @@ -483,7 +482,7 @@
>>>> config X86_MCE_INTEL
>>>>    bool "Intel MCE features"
>>>>    depends on X86_MCE && X86_LOCAL_APIC
>>>> -  default y
>>>> +  default n
>>>>    help
>>>>       Additional support for intel specific MCE features such as
>>>>       the thermal monitor.
>>> 
>>> This hunk should go.
>> 
>> This option will not appear under XEN, only for native?
>> depends on X86_MCE && X86_LOCAL_APIC && !X86_64_XEN
> 
> Whether it appears is not the question - you're changing the default
> value for no good reason.
> 
Yes. I need not change the default value now, it is true only in 
Native. We will not build those two specifc files.

>>>> 
>>>> +config X86_64_XEN_MCE
>>>> +  def_bool y
>>>> +  depends on X86_64_XEN && (X86_MCE_INTEL || X86_MCE_AMD)
>>>> +
>>> 
>>> I wonder if this wouldn't better be named X86_XEN_MCE (for
>>> consistency with a potential 32-bit implementation).
>>> 
>> 
>> This option will depends on X86_64_XEN && X86_MCE.
>> Yes, we could rename it. Yet this config file is under X86_64 sub
>> dir, also, seems 32bit system will not have mca support?
> 
> They do - see arch/i386/kernel/cpu/mcheck/.

Actually I mean 32 bit system might have rare hardware support. But
for consistency, yes, it's better to rename it as X86_XEN_MCE.
> 
> Jan


Attachment: intel_mce_dom0.patch
Description: intel_mce_dom0.patch

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel