WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] Re: [PATCH] ioemu: Cleanup the code of PCI passthrough.

To: Yuji Shimada <shimada-yxb@xxxxxxxxxxxxxxx>
Subject: Re: [Xen-devel] Re: [PATCH] ioemu: Cleanup the code of PCI passthrough.
From: Simon Horman <horms@xxxxxxxxxxxx>
Date: Mon, 23 Feb 2009 16:56:15 +1100
Cc: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>, Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
Delivery-date: Sun, 22 Feb 2009 21:56:44 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <20090223103532.84CE.27C06F64@xxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <18845.37702.133643.770177@xxxxxxxxxxxxxxxxxxxxxxxx> <20090220134809.DC68.27C06F64@xxxxxxxxxxxxxxx> <20090223103532.84CE.27C06F64@xxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mutt/1.5.18 (2008-05-17)
On Mon, Feb 23, 2009 at 10:40:22AM +0900, Yuji Shimada wrote:
> 
> The patch cleanups the code of PCI passthrough.
> 
> - Use LIST_FOREACH(). Don't use lh_first, le_next directly.
> - Use pci_{read, write}_block instead of "switch(len) case [124]
>   pci_{read, write}_{byte, word, long}();".
> - Eliminate duplicate codes using PT_MEARGE_VALUE macro.
> - Define PCI_ERR_* macro in pass-through.h if libpci is old.
> - Remove the unreasonable loop from pt_aer_reg_{save,restore}.
> - Enable pt_aer_reg_{save,restore}, even if libpci is old.
> - Fix ro_mask and remove unnecessary pt_xxx_reg_write functions.
> - Add "Error:" or "Warning:" to messages.
> - Remove verbose messages.
> 
> Thanks,
> --
> Yuji Shimada.
> 
> 
> Signed-off-by: Yuji Shimada <shimada-yxb@xxxxxxxxxxxxxxx>

Tested-by: Simon Horman <horms@xxxxxxxxxxxx>

-- 
Simon Horman
  VA Linux Systems Japan K.K., Sydney, Australia Satellite Office
  H: www.vergenet.net/~horms/             W: www.valinux.co.jp/en


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel