WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel] Re: [PATCH] CPUIDLE: revise tsc-save/restore to avoid big ts

To: "Wei, Gang" <gang.wei@xxxxxxxxx>
Subject: [Xen-devel] Re: [PATCH] CPUIDLE: revise tsc-save/restore to avoid big tsc skew between cpus
From: Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
Date: Fri, 05 Dec 2008 14:47:41 +0000
Cc: "Tian, Kevin" <kevin.tian@xxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Fri, 05 Dec 2008 06:48:04 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <C55ED7B9.9C5%keir.fraser@xxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AclWoeM2xc+X6mj6QOaQHsyxDmpzagAFRoNpAACb7OAABH8KUAADs+LEAAOM+Xw=
Thread-topic: [PATCH] CPUIDLE: revise tsc-save/restore to avoid big tsc skew between cpus
User-agent: Microsoft-Entourage/12.14.0.081024
On 05/12/2008 13:06, "Keir Fraser" <keir.fraser@xxxxxxxxxxxxx> wrote:

>> Below patch should be what you expected. It will still bring continuously
>> increasing tsc skew. If I pin all domains' vcpus on 1 pcpu, the skew is
>> increasing faster.
> 
> I applied a modified version of this as c/s 18873. Primarily I removed
> scale_time() and replaced with a simpler reciprocal function which is applied
> to scale factors to invert them. Please take a look.

I should have tested the reciprocal function before checkin. A fixed (and
now rather less simple) version is in c/s 18875.

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel