Re: [Xen-devel] [PATCH 1/1] Xen PV support for hugepages

To:	Dave McCracken <dcm@xxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxxxx>
Subject:	Re: [Xen-devel] [PATCH 1/1] Xen PV support for hugepages
From:	Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
Date:	Thu, 06 Nov 2008 13:54:35 +0000
Cc:	xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date:	Thu, 06 Nov 2008 05:54:38 -0800
Envelope-to:	www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to:	<200811060744.57275.dcm@xxxxxxxx>
List-help:	<mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id:	Xen developer discussion <xen-devel.lists.xensource.com>
List-post:	<mailto:xen-devel@lists.xensource.com>
List-subscribe:	<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe:	<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender:	xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index:	AclAFzOLceLumawKEd24bAAWy6hiGQ==
Thread-topic:	[Xen-devel] [PATCH 1/1] Xen PV support for hugepages
User-agent:	Microsoft-Entourage/11.4.0.080122

On 6/11/08 13:44, "Dave McCracken" <dcm@xxxxxxxx> wrote:

>> Also, the special code to deal with LDT pages in put_page_from_l1e() should
>> now also be required in put_page_from_l2e(). Perhaps that logic could be
>> moved into put_data_page()?
> 
> It looks to me like this is only done for PGT_seg_desc_page.  I don't think
> any hugepage can be of this type.  I can add it to put_data_page() if you
> think we need to be sure.

The data pages mapped by a superpage mapping aren't special. One of them
could certainly be PGT_seg_desc_page. Hence moving the logic into
put_data_page() makes sense.

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

WARNING - OLD ARCHIVES

xen-devel

Re: [Xen-devel] [PATCH 1/1] Xen PV support for hugepages