WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH 1/1] Xen PV support for hugepages

To: <dcm@xxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH 1/1] Xen PV support for hugepages
From: Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
Date: Wed, 05 Nov 2008 10:59:43 +0000
Cc:
Delivery-date: Wed, 05 Nov 2008 03:00:08 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <20081104154149.21144.75675.sendpatchset@xxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: Ack/NZtp2eFkeKsoEd2t7AAX8io7RQ==
Thread-topic: [Xen-devel] [PATCH 1/1] Xen PV support for hugepages
User-agent: Microsoft-Entourage/11.4.0.080122
On 4/11/08 15:41, "dcm@xxxxxxxx" <dcm@xxxxxxxx> wrote:

> This is the latest version of a patch that adds hugepage support to the Xen
> hypervisor in a PV environment.  It is against the latest xen-unstable tree
> on xenbits.xensource.com.  I believe this version addresses the comments
> made about the previous version of the patch.
> 
> Hugepage support must be enabled via the hypervisor command line option
> "allowhugepage".
> 
> It assumes the guest guarantees that the hugepage is physically aligned and
> contiguous.
> 
> There is currently no support in the tools for saving/restoring/migrating
> guests who use hugepages.
> 
> Note to the maintainers:  What else needs to be done for this patch to be
> considered for inclusion into the tree?

I cleaned it up, fixed some return codes, and applied as c/s 18756. It may
be worth Jan Beulich taking a quick look as the return-code conventions for
the get/put functions in mm.c is now rather convoluted. I think I got it
right but I'm not 100% sure. Indeed, Jan, it'd sure be nice to have some
comments explaining what the <0,=0,>0 codes mean from the various get/put
functions, and how they differ between the l1e variants and the others (I'm
pretty sure they do differ).

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel