WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] debuggers and hap_gva_to_gfn() in guest_walk.c

To: Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
Subject: Re: [Xen-devel] debuggers and hap_gva_to_gfn() in guest_walk.c
From: Tim Deegan <Tim.Deegan@xxxxxxxxxx>
Date: Thu, 6 Nov 2008 10:51:57 +0000
Cc: mukesh.rathor@xxxxxxxxxx, xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Thu, 06 Nov 2008 02:52:38 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <C537C715.1EEB2%keir.fraser@xxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <491213BF.8040300@xxxxxxxxxx> <C537C715.1EEB2%keir.fraser@xxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mutt/1.5.17 (2007-11-01)
At 21:56 +0000 on 05 Nov (1225922197), Keir Fraser wrote:
> This looks like a bug in hap_gva_to_gfn(). It should probably be using
> gfn_to_mfn() rather than gfn_to_mfn_current(). Tim, can you confirm?

In the current codebase, it's correct (all callers of paging_gva_to_gfn()
call with v == current) but changing it to use gfn_to_mfn() seems
more correcter.

Tim.

> On 5/11/08 21:44, "Mukesh Rathor" <mukesh.rathor@xxxxxxxxxx> wrote:
> 
> > 
> > Debugger/s would like to keep it's #ifdefs in xen minimal. Following would
> > help...
> > 
> > hap_gva_to_gfn():
> > 
> > 
> > +   if (v== current)
> >         mfn = mfn_x(gfn_to_mfn_current(gpfn, &p2mt));
> > +   else
> > +      mfn = mfn_x(gfn_to_mfn_foreign(v->domain, gpfn, &p2mt));
> > 
> > 
> > Thanks,
> > Mukesh
> > 
> > 
> > _______________________________________________
> > Xen-devel mailing list
> > Xen-devel@xxxxxxxxxxxxxxxxxxx
> > http://lists.xensource.com/xen-devel
> 
> 

-- 
Tim Deegan <Tim.Deegan@xxxxxxxxxx>
Principal Software Engineer, Citrix Systems (R&D) Ltd.
[Company #02300071, SL9 0DZ, UK.]

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>