WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

RE: [Xen-devel][PATCH 3/5] Add cpufreq pwr mgmt to Xen

To: "Keir Fraser" <keir.fraser@xxxxxxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: RE: [Xen-devel][PATCH 3/5] Add cpufreq pwr mgmt to Xen
From: "Liu, Jinsong" <jinsong.liu@xxxxxxxxx>
Date: Wed, 14 May 2008 14:01:17 +0800
Delivery-date: Tue, 13 May 2008 23:02:04 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <C44F1627.20A2B%keir.fraser@xxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <9D7649D18729DE4BB2BD7B494F7FEDC201400CB9@xxxxxxxxxxxxxxxxxxxxxxxxxxxx> <C44F1627.20A2B%keir.fraser@xxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: Aci0pum5DchKJJryTjCAyBnEoEeG2AAMDsoTACvKrCA=
Thread-topic: [Xen-devel][PATCH 3/5] Add cpufreq pwr mgmt to Xen
Keir,

I've updated my patches accroding to your comments.
[PATCH 2/5] [dom0] pm_dom0_1_px.patch: update public header files.
[PATCH 3/5] [xen] pm_xen_1_hypercall.patch: update public header files,
and common/domain.c

Thanks,
Jinsong

-----Original Message-----
From: Keir Fraser [mailto:keir.fraser@xxxxxxxxxxxxx] 
Sent: Tuesday, May 13, 2008 4:56 PM
To: Liu, Jinsong; xen-devel@xxxxxxxxxxxxxxxxxxx
Subject: Re: [Xen-devel][PATCH 3/5] Add cpufreq pwr mgmt to Xen

On 13/5/08 04:10, "Liu, Jinsong" <jinsong.liu@xxxxxxxxx> wrote:

> Get ACPI Px from dom0 and chose Px controller
> 
> Add platform op hypercall case to get ACPI Px info from dom0.
> Chose Px controller from dom0 (cpufreq=dom0-kernel)
> or hypervisor (cpufreq=xen-cpufreq)

No gcc-specific attributes in the public header files. This means no
__attribute__((packed)). Please fix that.

Also why declare a local variable 'a' in your changes to
common/domain.c?

 -- Keir



Attachment: pm_dom0_1_px.patch
Description: pm_dom0_1_px.patch

Attachment: pm_xen_1_hypercall.patch
Description: pm_xen_1_hypercall.patch

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel