WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

RE: [Xen-devel][PATCH 3/5] Add cpufreq pwr mgmt to Xen

To: "Keir Fraser" <keir.fraser@xxxxxxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: RE: [Xen-devel][PATCH 3/5] Add cpufreq pwr mgmt to Xen
From: "Liu, Jinsong" <jinsong.liu@xxxxxxxxx>
Date: Tue, 13 May 2008 17:34:34 +0800
Delivery-date: Tue, 13 May 2008 02:35:58 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <C44F1627.20A2B%keir.fraser@xxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <9D7649D18729DE4BB2BD7B494F7FEDC201400CB9@xxxxxxxxxxxxxxxxxxxxxxxxxxxx> <C44F1627.20A2B%keir.fraser@xxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: Aci0pum5DchKJJryTjCAyBnEoEeG2AAMDsoTAAEUb1A=
Thread-topic: [Xen-devel][PATCH 3/5] Add cpufreq pwr mgmt to Xen
Thanks Keir,

I will fix gcc-specific attributes in public header files ASAP.

I add a local variable 'a' in common/domain.c, since need to do '
xen_processor_pmbits &= (~a);'
If we directly use ' xen_processor_pmbits &= (~XEN_PROCESSOR_PM_PX)' may
result in some align issue if xen_processor_pmbits is not 32bits
variable.
So I add 'a' with same type as 'xen_processor_pmbits'.

Regards,
Jinsong

-----Original Message-----
From: Keir Fraser [mailto:keir.fraser@xxxxxxxxxxxxx] 
Sent: Tuesday, May 13, 2008 4:56 PM
To: Liu, Jinsong; xen-devel@xxxxxxxxxxxxxxxxxxx
Subject: Re: [Xen-devel][PATCH 3/5] Add cpufreq pwr mgmt to Xen

On 13/5/08 04:10, "Liu, Jinsong" <jinsong.liu@xxxxxxxxx> wrote:

> Get ACPI Px from dom0 and chose Px controller
> 
> Add platform op hypercall case to get ACPI Px info from dom0.
> Chose Px controller from dom0 (cpufreq=dom0-kernel)
> or hypervisor (cpufreq=xen-cpufreq)

No gcc-specific attributes in the public header files. This means no
__attribute__((packed)). Please fix that.

Also why declare a local variable 'a' in your changes to
common/domain.c?

 -- Keir




_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel