WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] long latency of domain shutdown

To: Jan Beulich <jbeulich@xxxxxxxxxx>
Subject: Re: [Xen-devel] long latency of domain shutdown
From: Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
Date: Thu, 08 May 2008 15:38:14 +0100
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Thu, 08 May 2008 07:38:51 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <48232A53.76E4.0078.0@xxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AcixGSVpY8zewB0MEd28OwAX8io7RQ==
Thread-topic: [Xen-devel] long latency of domain shutdown
User-agent: Microsoft-Entourage/11.4.0.080122
On 8/5/08 15:29, "Jan Beulich" <jbeulich@xxxxxxxxxx> wrote:

> Hmm, storing this in page_info seems questionable to me. It'd be at
> least 18 bits (on x86-64) that we'd need. I think this rather has to go
> into struct vcpu.

We can, for example, reuse tlbflush_timestamp for this purpose. Stick it in
the vcpu structure and I think we make life hard for ourselves. What if the
guest does not resume the hypercall, for example? What if the guest goes and
tries to execute a different hypercall instead?

> But what worries me more is that (obviously) any affected page will
> have to have its PGT_validated bit kept clear, which could lead to
> undesirable latencies in spin loops on other vcpus waiting for it to
> become set. In the worst case this could lead to deadlocks (at least
> in the UP case or when multiple vCPU-s of one guest are pinned to
> the same physical CPU) afaics. Perhaps this part could indeed be
> addressed with a new PGT_* bit, upon which waiters could exit
> their spin loops and consider themselves preempted.

Yes, the page state machine does need some more careful thought. I'm pretty
sure we have enough page state bits though.

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel