xen-devel

[Top] [All Lists]

[Xen-devel] [PATCH] minios: clear FB content

from [Samuel Thibault]

[Permanent Link][Original]

To:	xen-devel@xxxxxxxxxxxxxxxxxxx
Subject:	[Xen-devel] [PATCH] minios: clear FB content
From:	Samuel Thibault <samuel.thibault@xxxxxxxxxxxxx>
Date:	Thu, 8 May 2008 15:34:26 +0100
Delivery-date:	Thu, 08 May 2008 07:34:48 -0700
Envelope-to:	www-data@xxxxxxxxxxxxxxxxxx
List-help:	<mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id:	Xen developer discussion <xen-devel.lists.xensource.com>
List-post:	<mailto:xen-devel@lists.xensource.com>
List-subscribe:	<http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe:	<http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Mail-followup-to:	Samuel Thibault <samuel.thibault@xxxxxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxx
Sender:	xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent:	Mutt/1.5.12-2006-07-14

minios: clear FB content since _xmalloc may return non-zeroed memory (in
debug mode, notably).

Signed-off-by: Samuel Thibault <samuel.thibault@xxxxxxxxxxxxx>

diff -r 2223ed7635d4 extras/mini-os/kernel.c
--- a/extras/mini-os/kernel.c   Thu May 08 13:59:03 2008 +0100
+++ b/extras/mini-os/kernel.c   Thu May 08 15:34:59 2008 +0100
@@ -302,13 +302,10 @@
 
     memsize = n * PAGE_SIZE;
     fb = _xmalloc(memsize, PAGE_SIZE);
+    memset(fb, 0, memsize);
     mfns = xmalloc_array(unsigned long, n);
-    for (i = 0; i < n; i++) {
-        /* trigger CoW */
-        ((char *) fb) [i * PAGE_SIZE] = 0;
-        barrier();
+    for (i = 0; i < n; i++)
         mfns[i] = virtual_to_mfn((char *) fb + i * PAGE_SIZE);
-    }
     fb_dev = init_fbfront(NULL, mfns, WIDTH, HEIGHT, DEPTH, line_length, n);
     xfree(mfns);
     if (!fb_dev) {

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

[More with this subject...]

<Prev in Thread]	Current Thread	[Next in Thread>
[Xen-devel] [PATCH] minios: clear FB content, Samuel Thibault <=

Previous by Date:	Re: [Xen-devel] long latency of domain shutdown, Jan Beulich
Next by Date:	Re: [Xen-devel] long latency of domain shutdown, Keir Fraser
Previous by Thread:	[Xen-devel] [PATCH] - fix/improve error handling for failed suspend/migrate, Steven Hand
Next by Thread:	[Xen-devel] QEMU "drive_init()" Disk Format Security Bypass, Eren Türkay
Indexes:	[Date] [Thread] [Top] [All Lists]