WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH] Fix ioemu compile

To: Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>, Trolle Selander <trolle.selander@xxxxxxxxx>, "Daniel P. Berrange" <berrange@xxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] Fix ioemu compile
From: Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>
Date: Fri, 07 Dec 2007 11:17:30 +0000
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx, John Levon <levon@xxxxxxxxxxxxxxxxx>
Delivery-date: Fri, 07 Dec 2007 03:12:19 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <C37ED9FD.110EE%Keir.Fraser@xxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: Acg4wWJaoMFfzKS0EdyZsgAWy6hiGQAAV8Rd
Thread-topic: [Xen-devel] [PATCH] Fix ioemu compile
User-agent: Microsoft-Entourage/11.3.6.070618
So I propose:
#include <termios.h>
#include <sys/ioctl.h>

I think that will cover all cases. Is everyone happy with that?

 -- Keir

On 7/12/07 11:07, "Keir Fraser" <Keir.Fraser@xxxxxxxxxxxx> wrote:

I checked in John Levon’s original patch for now, but perhaps <sys/ioctl.h> would work?

 -- Keir

On 7/12/07 09:27, "Trolle Selander" <trolle.selander@xxxxxxxxx> wrote:

Unfortunately, sys/termios.h doesn't work on linux, at least on RHEL/Fedora. I knew it wasn't quite kosher to include asm/termios.h when I did it, but it was the only way I could get the termbit defines included. I was going to look for a clean solution, but forgot. It would seem bits/termios.h needs to be extended with the necessary stuff from asm/termios.h, but I'm not sure where/who to suggest that change.

On Dec 6, 2007 8:41 PM, Daniel P. Berrange <berrange@xxxxxxxxxx> wrote:
On Thu, Dec 06, 2007 at 07:35:20PM +0000, John Levon wrote:
> On Thu, Dec 06, 2007 at 11:31:35AM -0800, john.levon@xxxxxxx wrote:
>
> > serial.c was including another Linux-specific header.
> >
> > Signed-off-by: John Levon <john.levon@xxxxxxx>
> >
> > diff --git a/tools/ioemu/hw/serial.c b/tools/ioemu/hw/serial.c
> > --- a/tools/ioemu/hw/serial.c
> > +++ b/tools/ioemu/hw/serial.c
> > @@ -26,9 +26,15 @@
> >  #include <sys/time.h>
> >  #include <time.h>
> >  #include < assert.h>
> > -#include <asm/termios.h>
>
> Erm, or it looks like just making this be <sys/termios.h> will work too

Definitely. Including asm/ headers directly on Linux is frowned upon.

Dan.
--
|=- Red Hat, Engineering, Emerging Technologies, Boston.  +1 978 392 2496 -=|
|=-           Perl modules: http://search.cpan.org/~danberr/  <http://search.cpan.org/%7Edanberr/>               -=|
|=-               Projects: http://freshmeat.net/~danielpb/ <http://freshmeat.net/%7Edanielpb/>                -=|
|=-  GnuPG: 7D3B9505   F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505  -=|

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel