Re: [Xen-devel] [PATCH] Fix ioemu compile

On Thu, Dec 06, 2007 at 07:35:20PM +0000, John Levon wrote:
> On Thu, Dec 06, 2007 at 11:31:35AM -0800, john.levon@xxxxxxx wrote:
> 
> > serial.c was including another Linux-specific header.
> > 
> > Signed-off-by: John Levon <john.levon@xxxxxxx>
> > 
> > diff --git a/tools/ioemu/hw/serial.c b/tools/ioemu/hw/serial.c
> > --- a/tools/ioemu/hw/serial.c
> > +++ b/tools/ioemu/hw/serial.c
> > @@ -26,9 +26,15 @@
> >  #include <sys/time.h>
> >  #include <time.h>
> >  #include <assert.h>
> > -#include <asm/termios.h>
> 
> Erm, or it looks like just making this be <sys/termios.h> will work too

Definitely. Including asm/ headers directly on Linux is frowned upon.

Dan.
-- 
|=- Red Hat, Engineering, Emerging Technologies, Boston.  +1 978 392 2496 -=|
|=-           Perl modules: http://search.cpan.org/~danberr/              -=|
|=-               Projects: http://freshmeat.net/~danielpb/               -=|
|=-  GnuPG: 7D3B9505   F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505  -=| 

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread]

Current Thread

[Next in Thread>

Previous by Date:

Re: [Xen-devel] [PATCH] Fix ioemu compile, John Levon

Next by Date:

[Xen-devel] [xen-3.1-testing] ia64 updates, Alex Williamson

Previous by Thread:

Re: [Xen-devel] [PATCH] Fix ioemu compile, John Levon

Next by Thread:

Re: [Xen-devel] [PATCH] Fix ioemu compile, Trolle Selander

Indexes:

[Date] [Thread] [Top] [All Lists]