This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] [PATCH] Fix xenmon/xentrace compile on Solaris

To: xen-devel@xxxxxxxxxxxxxxxxxxx
Subject: Re: [Xen-devel] [PATCH] Fix xenmon/xentrace compile on Solaris
From: Mark Williamson <mark.williamson@xxxxxxxxxxxx>
Date: Thu, 9 Aug 2007 04:24:27 +0100
Cc: Keir Fraser <keir@xxxxxxxxxxxxx>, John Levon <john.levon@xxxxxxx>
Delivery-date: Wed, 08 Aug 2007 20:22:00 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <20070807135630.GA16983@xxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <ae465d2d2b2ec9ab3159.1186492441@xenbld> <C2DE36C6.13B58%keir@xxxxxxxxxxxxx> <20070807135630.GA16983@xxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: KMail/1.9.6
For the Xentrace side, I'd say:

> On Tue, Aug 07, 2007 at 02:48:38PM +0100, Keir Fraser wrote:
> >   1. Don't use argp at all in xentrace/xenmon -- do they really need
> > super-advanced argument parsing such that getopt will not suffice? As
> > low-level not-usually-user-visible daemons I would say that porting them
> > to getopt would be acceptable even if the command-line option syntax
> > needs changing a little to cleanly do so.

This is what I was going to suggest.  The existing syntax should probably work 
fine, argp just expresses it more nicely (IMO) at the expense of non-GNU 

> We'd presumed that somebody had gone out of their way to use argp for a
> reason. If it's not necessary we're certainly fine with doing that instead.

Nope, no reason :-)

As far as I'm concerned, feel free to drop argp and replace with getopt.  
Maintaining existing syntax might be nice, but isn't required.

As far as Xenmon is concerned, I didn't know it used argp.  The original 
authors might have some useful comment to make, but my guess would be that 
they used argp to match the existing practice in Xentrace.


Dave: Just a question. What use is a unicyle with no seat?  And no pedals!
Mark: To answer a question with a question: What use is a skateboard?
Dave: Skateboards have wheels.
Mark: My wheel has a wheel!

Xen-devel mailing list

<Prev in Thread] Current Thread [Next in Thread>