This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] [PATCH] Fix xenmon/xentrace compile on Solaris

To: <john.levon@xxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] Fix xenmon/xentrace compile on Solaris
From: Keir Fraser <keir@xxxxxxxxxxxxx>
Date: Tue, 07 Aug 2007 14:48:38 +0100
Delivery-date: Tue, 07 Aug 2007 06:46:31 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <ae465d2d2b2ec9ab3159.1186492441@xenbld>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AcfY+af65k7HO0TsEdyCkgAX8io7RQ==
Thread-topic: [Xen-devel] [PATCH] Fix xenmon/xentrace compile on Solaris
User-agent: Microsoft-Entourage/
That's a lot of code to include verbatim in our repository, especially for
two non-essential build targets.

There are two potential better alternatives:
  1. Don't use argp at all in xentrace/xenmon -- do they really need
super-advanced argument parsing such that getopt will not suffice? As
low-level not-usually-user-visible daemons I would say that porting them to
getopt would be acceptable even if the command-line option syntax needs
changing a little to cleanly do so.
  2. Is libargp available separately from libc? If so you could require
users to install it if they wish to build xentrace/xenmon. Or you could
maintain the libargp you posted out-of-tree.

 -- Keir

On 7/8/07 14:14, "john.levon@xxxxxxx" <john.levon@xxxxxxx> wrote:

> # HG changeset patch
> # User john.levon@xxxxxxx
> # Date 1186492378 25200
> # Node ID ae465d2d2b2ec9ab31598511fb35814ba6ab5602
> # Parent  1ddb3b21f4d8a6b449580ae45cf707f4b43198f9
> Fix xenmon/xentrace compile on Solaris
> The argp interface is only present in GNU libc. Include a local copy when
> compiling on Solaris, and fix a couple of a trivial compile problems.
> Signed-off-by: Tariq Magdon-Ismail <tariqmi@xxxxxxx>

Xen-devel mailing list

<Prev in Thread] Current Thread [Next in Thread>