WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] Re: A wrong assert in get_ioreq()?

To: Paul Samon <paul.samon@xxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: Re: [Xen-devel] Re: A wrong assert in get_ioreq()?
From: Keir Fraser <keir@xxxxxxxxxxxxx>
Date: Wed, 04 Jul 2007 14:22:23 +0100
Delivery-date: Wed, 04 Jul 2007 06:20:34 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <34cec8c90707040412s4aa16fcdlbdd252e42a05f76e@xxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: Ace+PlsomZh0PioxEdylUAAX8io7RQ==
Thread-topic: [Xen-devel] Re: A wrong assert in get_ioreq()?
User-agent: Microsoft-Entourage/11.3.3.061214
The lock is taken in, for example, hvm_vcpu_initialise(), which calles get_ioreq(v) with v!=current. So the assertion is correct as-is.

 -- Keir

On 4/7/07 12:12, "Paul Samon" <paul.samon@xxxxxxxxx> wrote:

Sorry, I meant the assert should "ASSERT(v == current)."
 
On 7/4/07, Paul Samon <paul.samon@xxxxxxxxx> wrote:
I don't think it should be
    ASSERT(v == current).
we don't get the lock first, and I think we needn't it.
 
Am I missing something?
 



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
<Prev in Thread] Current Thread [Next in Thread>