WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel] A wrong assert in get_ioreq()?

To: xen-devel@xxxxxxxxxxxxxxxxxxx
Subject: [Xen-devel] A wrong assert in get_ioreq()?
From: "Paul Samon" <paul.samon@xxxxxxxxx>
Date: Wed, 4 Jul 2007 19:05:20 +0800
Delivery-date: Wed, 04 Jul 2007 04:03:13 -0700
Dkim-signature: a=rsa-sha1; c=relaxed/relaxed; d=gmail.com; s=beta; h=domainkey-signature:received:received:message-id:date:from:to:subject:mime-version:content-type; b=W7V67Sn/XP9/HLAEQb+Ei7SSAaNm458i9KgfX+RBiJBrYKNokijlF0+97vFbaulH7fw0iYmi6iPcAqATvtaHuZNxPtLkDfdJgPRNPdo9CMLR0aYN5McHjFFTnT6aRRtJIsw23qD9qQsZ/xgLxgNLlkyPemUgqOGzYLGLWYI79kQ=
Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=received:message-id:date:from:to:subject:mime-version:content-type; b=TXCzOOL1K7bw0IbIxMac5RzUKAtZstdZk5vc2NlF6GM8DMVf3lFw1XMyn9c3xzI06piJkT4fb3VZdWSw3DRSziWvZnoN1N0ZPSDe/HXdd2O8VA/ujaM9BrQzYSven8gTtmb7+8WJgskupRW2Wvw+COQuN7FhfJKPXZsMg+4Ad0c=
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
In the function get_ioreq(),  there is a line:
    ASSERT((v == current) || spin_is_locked(&d->arch.hvm_domain.ioreq.lock ));
I don't think it should be
    ASSERT(v == current).
we don't get the lock first, and I think we needn't it.
 
Am I missing something?
 
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
<Prev in Thread] Current Thread [Next in Thread>