WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH] netfront: Lockdep fixes

To: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>, Jeremy Fitzhardinge <jeremy@xxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] netfront: Lockdep fixes
From: Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>
Date: Fri, 13 Apr 2007 15:22:41 +0100
Cc: andrei@xxxxxxxxxxxxx, xen-devel@xxxxxxxxxxxxxxxxxxx, Christian.Limpach@xxxxxxxxxxxxx
Delivery-date: Fri, 13 Apr 2007 07:20:36 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <E1HcKbQ-0002un-00@xxxxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: Acd91zHIcCcuMOnKEduH7gAWy6hiGQ==
Thread-topic: [Xen-devel] [PATCH] netfront: Lockdep fixes
User-agent: Microsoft-Entourage/11.3.3.061214
On 13/4/07 13:10, "Herbert Xu" <herbert@xxxxxxxxxxxxxxxxxxx> wrote:

> The ->poll method is guaranteed to be called with BH disabled so
> this isn't necessary.

Thanks.

>> @@ -1588,7 +1588,7 @@ static void netif_release_rx_bufs(struct
> 
> Just a minor nit.  This is normally called with BH disabled,
> except from uninit so you could put a local_bh_disable there
> instead.

That function's *only* called from uninit()!

> You can't enable BH with IRQs disabled.  Besides, for the sake of
> symmetry these two should be reversed.

Ack, I should have spotted this one, and the ditto.

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel