WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

RE: [Xen-devel] [PATCH] support protected mode mmio with non-zero CS bas

To: "Mats Petersson" <Mats.Petersson@xxxxxxx>
Subject: RE: [Xen-devel] [PATCH] support protected mode mmio with non-zero CS base
From: "Jan Beulich" <jbeulich@xxxxxxxxxx>
Date: Wed, 22 Nov 2006 12:24:50 +0100
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Wed, 22 Nov 2006 03:22:55 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <907625E08839C4409CE5768403633E0B018E1749@xxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <45640C04.76E4.0078.0@xxxxxxxxxx> <907625E08839C4409CE5768403633E0B018E1749@xxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
>Yes, but it's also possibly incorrect if the machine is in "big
>realmode", which is an entirely valid way to run code in x86 processors,
>and I think it's better to fix it "properly" than to have to fix it
>again when someone finds another fault in the code, because someone
>wrote some code differently. 

I meanwhile got convinced by Keir that this is indeed the better way.

>The next problem will of course be that data-fetches where the segment
>base is non-zero. I think the only case where that is likely to happen
>in mmio is for MOVS instructions, as everything else is presumably using
>the faulting address to know where the MMIO address is. But I'm OK with
>not fixing this right now. 

I intend to, and I suppose I'll find more places. The base address use is
only one part for string instructions - the more involved (or perhaps better
the one causing more overhead) is that for repeated ones, we'll now have
to do limit checks, as the CPU will have checked only the first item.

Jan

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel