WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] Re: [PATCH] make ballooning up to maxmem work

To: Glauber de Oliveira Costa <gcosta@xxxxxxxxxx>, Rik van Riel <riel@xxxxxxxxxx>
Subject: Re: [Xen-devel] Re: [PATCH] make ballooning up to maxmem work
From: Keir Fraser <keir@xxxxxxxxxxxxx>
Date: Wed, 22 Nov 2006 11:18:39 +0000
Cc: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Wed, 22 Nov 2006 03:18:51 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <20061122104021.GA2496@xxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AccOJ/WUM+a1mnobEduTKwAX8io7RQ==
Thread-topic: [Xen-devel] Re: [PATCH] make ballooning up to maxmem work
User-agent: Microsoft-Entourage/11.2.5.060620


On 22/11/06 10:40, "Glauber de Oliveira Costa" <gcosta@xxxxxxxxxx> wrote:

>>      case XENMEM_current_reservation:
>>      case XENMEM_maximum_reservation:
>> +    case XENMEM_maximum_memory:
>>          if ( copy_from_guest(&domid, arg, 1) )
>>              return -EFAULT;
> 
> This still makes use of d->max_pages in return. Isn't it supposed to
> change in the future too? IIRC, according to Keir, max_pages will track
> the _current_ number of pages, differing from tot_pages only in a brief
> timeframe in which you balloon, but tot_pages was not yet updated.

This adds a level of indirection at least, but really we may as well
implement the XENMEM_memory_map hypercall. Then there is no guest
modification required.

 -- Keir


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>