WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel] [Patch] tweak error reporting for bootloader errors in xm

To: xen-devel@xxxxxxxxxxxxxxxxxxx
Subject: [Xen-devel] [Patch] tweak error reporting for bootloader errors in xm
From: "Daniel P. Berrange" <berrange@xxxxxxxxxx>
Date: Mon, 6 Nov 2006 15:14:33 +0000
Delivery-date: Mon, 06 Nov 2006 07:15:02 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Reply-to: "Daniel P. Berrange" <berrange@xxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mutt/1.4.1i
The xm command does some basic validation of the 'bootloader' parameter
before trying to run it, however, the level of detail reported isn't as
clear as it could be.

For example if I typo the bootloader param it says:

  # xm create XenGuest1
  Using config file "XenGuest1".
  Error: Bootloader isn't executable

The attached patch makes it do an explicit check for path existance prior
to the one for executable permissions. It also prints out the path being
tested.

  # xm create XenGuest1
  Using config file "XenGuest1".
  Error: Bootloader '/usr/sbin/pygrub' does not exist


  Signed-off-by: Daniel P, Berrange <berrange@xxxxxxxxxx>

Regards,
Dan.
-- 
|=- Red Hat, Engineering, Emerging Technologies, Boston.  +1 978 392 2496 -=|
|=-           Perl modules: http://search.cpan.org/~danberr/              -=|
|=-               Projects: http://freshmeat.net/~danielpb/               -=|
|=-  GnuPG: 7D3B9505   F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505  -=| 

Attachment: xm-bootloader-errors.patch
Description: Text document

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
<Prev in Thread] Current Thread [Next in Thread>
  • [Xen-devel] [Patch] tweak error reporting for bootloader errors in xm, Daniel P. Berrange <=