WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] Vmxassist build failure on gcc 3.3.5

To: "Woller, Thomas" <thomas.woller@xxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: Re: [Xen-devel] Vmxassist build failure on gcc 3.3.5
From: Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>
Date: Thu, 19 Oct 2006 21:58:03 +0100
Delivery-date: Thu, 19 Oct 2006 14:09:25 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <683860AD674C7348A0BF0DE3918482F603666B67@xxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AcbznSeBTn7r3870TrOkcPhwGhDWtgAEdkCBAACOytAABAI1Jg==
Thread-topic: [Xen-devel] Vmxassist build failure on gcc 3.3.5
User-agent: Microsoft-Entourage/11.2.5.060620
On 19/10/06 8:06 pm, "Woller, Thomas" <thomas.woller@xxxxxxx> wrote:

>> I expect placing $DATA_SELECTOR in brackets $(DATA_SELECTOR)
>> will work. I expect the version of cpp is not able to pick
>> out a macro usage when it runs into adjacent punctuation.
>> 
> Yes. () works. Here is patch..
> Thanks for the help
> Tom
> 
> Signed-off-by: Tom Woller <thomas.woller@xxxxxxx>

Oh, the penny drops. It's because we now have -std=gnu99. I deliberately
strip that out of CFLAGS when building asm files in Xen itself, as it makes
gcc really unhappy (doesn't like #-prefixed end-of-line comments). Clearly
it's not partial to $-prefixed macro names either, with older gcc versions.

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>