[Xen-devel] Vmxassist build failure on gcc 3.3.5

["Woller, Thomas" <thomas.woller@xxxxxxx>]

Our build server is failing on xen-unstable.hg c/s 11822 in
tools/firmware/vmxassist/traps.S. 
hg annotate shows that the code hasn't changed for quite a while.  This
is 64bit and 32bit builds, trying 32bit pae now.

If I change the failing line in traps.S from:
        movl    $DATA_SELECTOR, %eax    /* make sure these are sane */
To:
        movl    DATA_SELECTOR, %eax     /* make sure these are sane */

Build picks up the #define of DATA_SELECTOR in machine.h, and builds
successfully.

The failure is with gcc 3.3.5, I just tried a local SLES10 gcc 4.0.2
version and it seems to work fine with either of the above asm lines,
and generates same opcodes.  
Should the "$" be removed?
Thanks,
  --Tom

Here is the failure:
with:
xec]      [exec] gcc  -m32 -march=i686 -DNDEBUG -std=gnu99 -Wall
-Wstrict-prototypes -Wno-unused-value      -DDEBUG -DTEXTADDR=0x000D0000
-I. -I../../../tools/libxc -fno-builtin -O2 -msoft-float -D__ASSEMBLY__
-DDEBUG -DTEXTADDR=0x000D0000 -c trap.S
  [sshexec]      [exec] gcc  -m32 -march=i686 -DNDEBUG -std=gnu99 -Wall
-Wstrict-prototypes -Wno-unused-value      -DDEBUG -DTEXTADDR=0x000D0000
-I. -I../../../tools/libxc -fno-builtin -O2 -msoft-float -c vm86.c
  [sshexec]      [exec] gcc  -m32 -march=i686 -DNDEBUG -std=gnu99 -Wall
-Wstrict-prototypes -Wno-unused-value      -DDEBUG -DTEXTADDR=0x000D0000
-I. -I../../../tools/libxc -fno-builtin -O2 -msoft-float -c setup.c
  [sshexec]      [exec] gcc  -m32 -march=i686 -DNDEBUG -std=gnu99 -Wall
-Wstrict-prototypes -Wno-unused-value      -DDEBUG -DTEXTADDR=0x000D0000
-I. -I../../../tools/libxc -fno-builtin -O2 -msoft-float -c util.c
  [sshexec]      [exec] cpp -P -DDEBUG -DTEXTADDR=0x000D0000
vmxassist.ld > vmxassist.tmp
  [sshexec]      [exec] ld -o vmxassist -melf_i386 -nostdlib
--fatal-warnings -N -T vmxassist.tmp head.o trap.o vm86.o setup.o util.o
  [sshexec]      [exec] trap.o(.text+0x308): In function `common_trap':

  [sshexec]      [exec] trap.S: undefined reference to `DATA_SELECTOR'




_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel