This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] odd vcpu_info accesses in xen/arch/x86/time.c

To: Jan Beulich <jbeulich@xxxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: Re: [Xen-devel] odd vcpu_info accesses in xen/arch/x86/time.c
From: Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>
Date: Wed, 30 Aug 2006 17:27:13 +0100
Delivery-date: Wed, 30 Aug 2006 09:27:40 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <44F471BA.76E4.0078.0@xxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AcbMUSYVZG+T6DhEEdux/QAKle7CWA==
Thread-topic: [Xen-devel] odd vcpu_info accesses in xen/arch/x86/time.c
User-agent: Microsoft-Entourage/

On 29/8/06 3:56 pm, "Jan Beulich" <jbeulich@xxxxxxxxxx> wrote:

> Is there a particular reason why in several places in this file, with a vcpu
> pointer
> at hand, the vcpu_info is accessed through
> v->domain->shared_info->vcpu_info[v->vcpu_id]
> rather than
> v->vcpu_info

No. They should be fixed.

 -- Keir

Xen-devel mailing list

<Prev in Thread] Current Thread [Next in Thread>