This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] [POWERPC/IA64] Updates required due to loader changes

On Wed, 2006-08-23 at 13:09 -0500, Hollis Blanchard wrote:
> On Wed, 2006-08-23 at 18:44 +0100, Ian Campbell wrote:
> > Does it make sense to add a token set of ELF notes to your kernels? I
> > think XEN_VERSION, GUEST_OS and GUEST_VERSION would do the job...
> I don't have any objection in principle.

   I don't have any objection to it either.  As Tristan mentioned for
ia64, we don't actually build the code in the proposed ia64 patch, so I
think we'll be fine for the moment.  One problem though is that
readnote.c will fail to build on all non-x86 architectures.  The patch
below makes it build, but I haven't actually tested the functionality.
PPC may want something similar.  Ian, could you commit this?  Thanks,


Signed-off-by: Alex Williamson <alex.williamson@xxxxxx>

diff -r d5eb5205ff35 tools/xcutils/readnotes.c
--- a/tools/xcutils/readnotes.c Thu Aug 24 16:25:49 2006 +0100
+++ b/tools/xcutils/readnotes.c Thu Aug 24 14:12:45 2006 -0600
@@ -22,7 +22,7 @@ typedef Elf32_Nhdr Elf_Nhdr;
 typedef Elf32_Nhdr Elf_Nhdr;
 typedef Elf32_Half Elf_Half;
 typedef Elf32_Word Elf_Word;
-#elif defined(__x86_64__)
+#elif defined(__x86_64__) || defined(__ia64__)
 typedef Elf64_Ehdr Elf_Ehdr;
 typedef Elf64_Nhdr Elf_Nhdr;
 typedef Elf64_Half Elf_Half;

Xen-devel mailing list

<Prev in Thread] Current Thread [Next in Thread>