This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] Xen bug or sky2 device driver bug?

To: Gerd Hoffmann <kraxel@xxxxxxx>
Subject: Re: [Xen-devel] Xen bug or sky2 device driver bug?
From: Jae-Wan Jang <jwjang@xxxxxxxxxxxxxxxxxx>
Date: Fri, 18 Aug 2006 20:00:06 +0900
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Fri, 18 Aug 2006 06:25:52 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <44E57744.8030203@xxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <44E5713A.2050106@xxxxxxxxxxxxxxxxxx> <44E57744.8030203@xxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Thunderbird 1.5 (Windows/20051201)
Thank you, Gerd Hoffmann.

Your patch works very well.
I can use both two NICs without problems.

Jae-Wan Jang

Gerd Hoffmann 쓴 글:
Is it bug of Xen or sky2 device?

Most likely bridging code, try the patch below (reminds /me that I
wanted to forward that one to the networking folks ...)



Subject: nf_bridge: ethernet header is 14 not 16 bytes From: jbeulich@xxxxxxxxxx Acked-by: kraxel@xxxxxxx References: 150410 The bridge netfilter code saves two more bytes that it should. In most cases it doesn't hurt because many drivers use NET_IP_ALIGN to make the IP header aligned, so there are two extra bytes head room available. Some drivers don't do that though (sky2 for example), so copying accesses data outside the skbuff data allocation. On xen kernels this can kill the machine with a page fault due to the way how skbuffs are allocated and the memory is managed. --- include/linux/netfilter_bridge.h | 2 +- net/bridge/br_netfilter.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) --- linux-2.6.17.orig/include/linux/netfilter_bridge.h +++ linux-2.6.17/include/linux/netfilter_bridge.h @@ -57,7 +57,7 @@ void nf_bridge_maybe_copy_header(struct memcpy(skb->data - 18, skb->nf_bridge->data, 18); skb_push(skb, 4); } else - memcpy(skb->data - 16, skb->nf_bridge->data, 16); + memcpy(skb->data - 14, skb->nf_bridge->data, 14); } } --- linux-2.6.17.orig/net/bridge/br_netfilter.c +++ linux-2.6.17/net/bridge/br_netfilter.c @@ -124,7 +124,7 @@ static inline struct nf_bridge_info *nf_ static inline void nf_bridge_save_header(struct sk_buff *skb) { - int header_size = 16; + int header_size = 14; if (skb->protocol == htons(ETH_P_8021Q)) header_size = 18;

_______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxxxxxxxx http://lists.xensource.com/xen-devel
Xen-devel mailing list