WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH] linux: don't bring up CPUs that can never be use

To: Jan Beulich <jbeulich@xxxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] linux: don't bring up CPUs that can never be used
From: Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>
Date: Mon, 14 Aug 2006 15:11:44 +0100
Delivery-date: Mon, 14 Aug 2006 07:12:03 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <44E09F66.76E4.0078.0@xxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: Aca/q5I20ISoOiueEduTIwAKle7CWA==
Thread-topic: [Xen-devel] [PATCH] linux: don't bring up CPUs that can never be used
User-agent: Microsoft-Entourage/11.2.5.060620


On 14/8/06 3:05 pm, "Jan Beulich" <jbeulich@xxxxxxxxxx> wrote:

> I think considering cpu_possible_map/cpu_present_map would be safer
> here,
> which is why I made the loop run over cpu_present_map. __cpu_up
> wouldn't
> be sufficient for setting this up then. I am, however, not sure whether
> these
> maps ever get accessed for non-online CPUs, so your suggestion might
> well
> work.

x86_64 seems to leave the setup of those maps until the CPU has started
running, but before setting cpu_online_map. So it should be fine for us to
do the same and so delete the loop. I'll apply it separately from your patch
though.

 -- Keir
 



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel