This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] [PATCH] linux: don't bring up CPUs that can never be use

To: "Keir Fraser" <Keir.Fraser@xxxxxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] linux: don't bring up CPUs that can never be used
From: "Jan Beulich" <jbeulich@xxxxxxxxxx>
Date: Mon, 14 Aug 2006 15:23:50 +0200
Delivery-date: Mon, 14 Aug 2006 06:23:54 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <C1063627.D4F%Keir.Fraser@xxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <44E0904E.76E4.0078.0@xxxxxxxxxx> <C1063627.D4F%Keir.Fraser@xxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
>> Without this, "nosmp" or "max_cpus=" Linux command line options are
>> being ignored.
>> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxxxx>
>I'm a little bit wary of the second hunk. Although it's probably okay,
is it
>actually required? Looks like the first hunk is what fixes the issue.

It's probably not strictly required, but sill better than iterating
over NR_CPUS, as
that is what mainline is in the process of phasing out. The only
difference I can
see to the results of the original code is that for cpu 0 the two array
now also get (re-)initialized here - but the value stored should be the
same as
may have been stored earlier.


Xen-devel mailing list