This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] Re: [PATCH 8 of 13] Add a bootparameter to reserve high

To: Rusty Russell <rusty@xxxxxxxxxxxxxxx>
Subject: Re: [Xen-devel] Re: [PATCH 8 of 13] Add a bootparameter to reserve high linear address space for hypervisors
From: Andi Kleen <ak@xxxxxxx>
Date: Wed, 2 Aug 2006 06:36:58 +0200
Cc: Andrew Morton <akpm@xxxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx>, virtualization@xxxxxxxxxxxxxx, Linux Kernel <linux-kernel@xxxxxxxxxxxxxxx>, Chris Wright <chrisw@xxxxxxxxxxxx>, Ian Pratt <ian.pratt@xxxxxxxxxxxxx>, "Eric W. Biederman" <ebiederm@xxxxxxxxxxxx>, Christoph Lameter <clameter@xxxxxxx>
Delivery-date: Tue, 01 Aug 2006 21:37:23 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <1154493226.2570.50.camel@xxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <0adfc39039c79e4f4121.1154462446@ezr> <200608020621.22827.ak@xxxxxxx> <1154493226.2570.50.camel@xxxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: KMail/1.9.3
On Wednesday 02 August 2006 06:33, Rusty Russell wrote:
> On Wed, 2006-08-02 at 06:21 +0200, Andi Kleen wrote:
> > >   I think you misunderstand the purpose of parse_early_param?  It is
> > > designed to be called directly by the arch at some point (it is
> > > idempotent, so the second call in init/main.c does nothing if the arch
> > > has called it).  ie. in i386, it replaces parse_cmdline_early().
> > 
> > Ah I didn't realize that. But why is there a second call in init/main.c?  
> > Looks like a big hack to me. Someone was too lazy to add it to all 
> > architectures?
> Yes.  Someone == me.  I didn't want to hack it into all archs, I wanted
> archs to actually use it, and you can see that's not a trivial patch...
> Once all archs use it, we can probably clean up setup_arch() not to take
> the char** and simply use the global saved_command_line directly.  At
> this rate, that'll be around 2012 8)

Please just make a proper patch - either add a call to it to all setup_archs,
or add a call to before setup_arch in init/main.c. While such ifdefs
for specific architecture hacks are more popular lately it doesn't mean they 
are a good idea.

I hope there aren't any existing architectures that use it in the middle
of setup_arch or rely on it being after setup_arch.


Xen-devel mailing list

<Prev in Thread] Current Thread [Next in Thread>