This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


[Xen-devel] Re: [PATCH 8 of 13] Add a bootparameter to reserve high line

To: Andi Kleen <ak@xxxxxxx>
Subject: [Xen-devel] Re: [PATCH 8 of 13] Add a bootparameter to reserve high linear address space for hypervisors
From: Rusty Russell <rusty@xxxxxxxxxxxxxxx>
Date: Wed, 02 Aug 2006 10:48:04 +1000
Cc: Andrew Morton <akpm@xxxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx>, Ian Pratt <ian.pratt@xxxxxxxxxxxxx>, Linux Kernel <linux-kernel@xxxxxxxxxxxxxxx>, Chris Wright <chrisw@xxxxxxxxxxxx>, virtualization@xxxxxxxxxxxxxx, "Eric W. Biederman" <ebiederm@xxxxxxxxxxxx>, Christoph Lameter <clameter@xxxxxxx>
Delivery-date: Tue, 01 Aug 2006 17:48:42 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <200608012347.20556.ak@xxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <0adfc39039c79e4f4121.1154462446@ezr> <200608012347.20556.ak@xxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
On Tue, 2006-08-01 at 23:47 +0200, Andi Kleen wrote:
>  > +          /*
> > +            * reservedtop=size reserves a hole at the top of the kernel
> > +            * address space which a hypervisor can load into later.
> > +            * Needed for dynamically loaded hypervisors, so relocating
> > +            * the fixmap can be done before paging initialization.
> > +            * This hole must be a multiple of 4M.
> > +            */
> > +           else if (!memcmp(from, "reservedtop=", 12)) {
> > +                   unsigned long reserved = memparse(from+12, &from);
> > +                   reserved &= ~0x3fffff;
> > +                   set_fixaddr_top(-reserved);
> > +           }
> You need to add a dummy __setup for it, otherwise it will end up in
> init's environments or be warned about.

Ewww, it's not the only one.  This whole function should be replaced
with a whole heap of early_param()s and a call to parse_early_param().

I only implemented parse_early_param two years ago; maybe it is time for
i386 to use it...

I'll create a patch,
Help! Save Australia from the worst of the DMCA: http://linux.org.au/law

Xen-devel mailing list

<Prev in Thread] Current Thread [Next in Thread>