This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


[Xen-devel] Re: [5/11] [NET] back: Replace netif->active with netif_carr

To: Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>
Subject: [Xen-devel] Re: [5/11] [NET] back: Replace netif->active with netif_carrier_ok
From: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Date: Fri, 28 Jul 2006 18:06:38 +1000
Cc: Xen Development Mailing List <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Fri, 28 Jul 2006 01:07:16 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <7608d0845e96fb8a289c3b814b6a8467@xxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <20060707141634.GA12031@xxxxxxxxxxxxxxxxxxx> <20060707141902.GF12031@xxxxxxxxxxxxxxxxxxx> <7608d0845e96fb8a289c3b814b6a8467@xxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mutt/1.5.9i
On Thu, Jul 27, 2006 at 02:11:01PM +0100, Keir Fraser wrote:
> netif->active is also conditional on whether or not the interface is 
> open ('running'). So it's not as good a fit for netif_carrier as the 
> status field you similarly replaced in netfront.
> Perhaps you could replace the netback status field 
> (CONNECTED/DISCONNECTED) instead? I think the extra value DISCONNECTING 
> is not really necessary any more, so it should map onto the boolean 
> netif_carrier okay.
> Then ->active could also potentially be removed. It would correspond to 
> netif_running&&netif_carrier_ok.

Good point.  I've made the carrier correspond to CONNECTED/DISCONNECTED
and added the netif_running tests.

Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Xen-devel mailing list

<Prev in Thread] Current Thread [Next in Thread>