This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


[Xen-devel] Re: [5/11] [NET] back: Replace netif->active with netif_carr

To: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Subject: [Xen-devel] Re: [5/11] [NET] back: Replace netif->active with netif_carrier_ok
From: Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>
Date: Thu, 27 Jul 2006 14:11:01 +0100
Cc: Xen Development Mailing List <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Thu, 27 Jul 2006 06:11:21 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <20060707141902.GF12031@xxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <20060707141634.GA12031@xxxxxxxxxxxxxxxxxxx> <20060707141902.GF12031@xxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx

On 7 Jul 2006, at 15:19, Herbert Xu wrote:

[NET] back: Replace netif->active with netif_carrier_ok

The connection status to the frontend can be represented using
netif_carrier_ok instead of netif->active.  As a result, we delay
the construction of the dev qdisc until the carrier comes on.  This
is a prerequisite for adding a tx queue.

Signed-off-by: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>

netif->active is also conditional on whether or not the interface is open ('running'). So it's not as good a fit for netif_carrier as the status field you similarly replaced in netfront.

Perhaps you could replace the netback status field (CONNECTED/DISCONNECTED) instead? I think the extra value DISCONNECTING is not really necessary any more, so it should map onto the boolean netif_carrier okay.

Then ->active could also potentially be removed. It would correspond to netif_running&&netif_carrier_ok.

 -- Keir

Xen-devel mailing list

<Prev in Thread] Current Thread [Next in Thread>